From patchwork Sat Jun 22 12:02:52 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Emil Goode X-Patchwork-Id: 2765661 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id C5A1C9F472 for ; Sat, 22 Jun 2013 12:03:28 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1AF9C20103 for ; Sat, 22 Jun 2013 12:03:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4BA5A200FF for ; Sat, 22 Jun 2013 12:03:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756106Ab3FVMDU (ORCPT ); Sat, 22 Jun 2013 08:03:20 -0400 Received: from mail-la0-f41.google.com ([209.85.215.41]:38208 "EHLO mail-la0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754586Ab3FVMDT (ORCPT ); Sat, 22 Jun 2013 08:03:19 -0400 Received: by mail-la0-f41.google.com with SMTP id fn20so8511468lab.14 for ; Sat, 22 Jun 2013 05:03:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=GWu/nSjCcCx6mfbCiY84TfGrB504CB/zYJm62/z4kgM=; b=fPucQzgUksvQhrDI15jCfGCXSiFo0I864C+0tff+9Ztyi1BQA830VqP6zVHGqvoNUs fFXutgVpnZV+eCo30o2vy04IcrOEW5IEmHKorgl7rZu4/rBAPJRJzTRJFGihUYU4koo1 f9iA6qR/uPSsO4yeVnyflL6tG1rBgREeAcCfO/aUQ3B14PBgotePmORJDxQZ9+mTFSio dLix2eUYL5pzO3ZfBQYcZmp3ndGjNB5dwo8+0f9uXRdsm6X6cZcYpchF5WhQ7Ff7i7CU fH42Na1oU9ZUyesQVS2aWjdVnQmJr+joNIkQsSZ3l0Tu+vJVbDdaEOGzQ3Qzn4l5RlHO 5bfA== X-Received: by 10.152.1.134 with SMTP id 6mr7832585lam.16.1371902597675; Sat, 22 Jun 2013 05:03:17 -0700 (PDT) Received: from localhost.localdomain (c193-14-104-184.cust.tele2.se. [193.14.104.184]) by mx.google.com with ESMTPSA id b8sm3295911lah.0.2013.06.22.05.03.16 for (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 22 Jun 2013 05:03:16 -0700 (PDT) From: Emil Goode To: mchehab@redhat.com, hans.verkuil@cisco.com, linux@rainbow-software.org, prabhakar.csengg@gmail.com, crope@iki.fi Cc: linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org, Emil Goode Subject: [PATCH] [media] saa7134: Fix sparse warnings by adding __user annotation Date: Sat, 22 Jun 2013 14:02:52 +0200 Message-Id: <1371902572-7925-1-git-send-email-emilgoode@gmail.com> X-Mailer: git-send-email 1.7.10.4 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Adding a __user annotation fixes the following sparse warnings. drivers/media/pci/saa7134/saa7134-video.c:1578:45: warning: incorrect type in initializer (different address spaces) drivers/media/pci/saa7134/saa7134-video.c:1578:45: expected struct v4l2_clip *clips drivers/media/pci/saa7134/saa7134-video.c:1578:45: got struct v4l2_clip [noderef] *clips drivers/media/pci/saa7134/saa7134-video.c:1589:26: warning: incorrect type in assignment (different address spaces) drivers/media/pci/saa7134/saa7134-video.c:1589:26: expected struct v4l2_clip [noderef] *clips drivers/media/pci/saa7134/saa7134-video.c:1589:26: got struct v4l2_clip *clips Signed-off-by: Emil Goode --- drivers/media/pci/saa7134/saa7134-video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/saa7134/saa7134-video.c b/drivers/media/pci/saa7134/saa7134-video.c index e3457ae..e12bbd8 100644 --- a/drivers/media/pci/saa7134/saa7134-video.c +++ b/drivers/media/pci/saa7134/saa7134-video.c @@ -1575,7 +1575,7 @@ static int saa7134_g_fmt_vid_overlay(struct file *file, void *priv, { struct saa7134_fh *fh = priv; struct saa7134_dev *dev = fh->dev; - struct v4l2_clip *clips = f->fmt.win.clips; + struct v4l2_clip __user *clips = f->fmt.win.clips; u32 clipcount = f->fmt.win.clipcount; int err = 0; int i;