diff mbox

[4/7] em28xx-audio: disconnect before freeing URBs

Message ID 1389567649-26838-5-git-send-email-m.chehab@samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Mauro Carvalho Chehab Jan. 12, 2014, 11 p.m. UTC 
URBs might be in usage. Disconnect the device before freeing
them.

Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
---
 drivers/media/usb/em28xx/em28xx-audio.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Frank Schäfer Jan. 13, 2014, 6:47 p.m. UTC | #1 
On 13.01.2014 00:00, Mauro Carvalho Chehab wrote:
> URBs might be in usage. Disconnect the device before freeing
> them.
>
> Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
> ---
>   drivers/media/usb/em28xx/em28xx-audio.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/usb/em28xx/em28xx-audio.c b/drivers/media/usb/em28xx/em28xx-audio.c
> index 8e959dae8358..cdc2fcf3e05e 100644
> --- a/drivers/media/usb/em28xx/em28xx-audio.c
> +++ b/drivers/media/usb/em28xx/em28xx-audio.c
> @@ -958,6 +958,7 @@ static int em28xx_audio_fini(struct em28xx *dev)
>   		return 0;
>   	}
>   
> +	snd_card_disconnect(dev->adev.sndcard);
>   	em28xx_audio_free_urb(dev);
>   
>   	if (dev->adev.sndcard) {

Reviewed-by: Frank Schäfer <fschaefer.oss@googlemail.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/media/usb/em28xx/em28xx-audio.c b/drivers/media/usb/em28xx/em28xx-audio.c
index 8e959dae8358..cdc2fcf3e05e 100644
--- a/drivers/media/usb/em28xx/em28xx-audio.c
+++ b/drivers/media/usb/em28xx/em28xx-audio.c
@@ -958,6 +958,7 @@  static int em28xx_audio_fini(struct em28xx *dev)
 		return 0;
 	}
 
+	snd_card_disconnect(dev->adev.sndcard);
 	em28xx_audio_free_urb(dev);
 
 	if (dev->adev.sndcard) {