| Message ID | 1396017313-3990-3-git-send-email-sakari.ailus@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Sakari, What happened to this patch ? 1/3 and 3/3 from the same series seem to have been applied, but not 2/3. On Friday 28 March 2014 16:35:12 Sakari Ailus wrote: > The smiapp driver is the owner of the sub-devices exposed by the smiapp > driver. This prevents unloading the module whilst it's in use. > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> > --- > drivers/media/i2c/smiapp/smiapp-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/smiapp/smiapp-core.c > b/drivers/media/i2c/smiapp/smiapp-core.c index 69c11ec..5179cf4 100644 > --- a/drivers/media/i2c/smiapp/smiapp-core.c > +++ b/drivers/media/i2c/smiapp/smiapp-core.c > @@ -2569,7 +2569,7 @@ static int smiapp_registered(struct v4l2_subdev > *subdev) > > this->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; > this->sd.internal_ops = &smiapp_internal_ops; > - this->sd.owner = NULL; > + this->sd.owner = THIS_MODULE; > v4l2_set_subdevdata(&this->sd, client); > > rval = media_entity_init(&this->sd.entity,
On Thu, Jul 17, 2014 at 12:22:47PM +0200, Laurent Pinchart wrote: > Hi Sakari, > > What happened to this patch ? 1/3 and 3/3 from the same series seem to have > been applied, but not 2/3. I think this must have fallen through the cracks when I added a number of other patches to the set. Thanks for notifying me.
diff --git a/drivers/media/i2c/smiapp/smiapp-core.c b/drivers/media/i2c/smiapp/smiapp-core.c index 69c11ec..5179cf4 100644 --- a/drivers/media/i2c/smiapp/smiapp-core.c +++ b/drivers/media/i2c/smiapp/smiapp-core.c @@ -2569,7 +2569,7 @@ static int smiapp_registered(struct v4l2_subdev *subdev) this->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; this->sd.internal_ops = &smiapp_internal_ops; - this->sd.owner = NULL; + this->sd.owner = THIS_MODULE; v4l2_set_subdevdata(&this->sd, client); rval = media_entity_init(&this->sd.entity,
The smiapp driver is the owner of the sub-devices exposed by the smiapp driver. This prevents unloading the module whilst it's in use. Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> --- drivers/media/i2c/smiapp/smiapp-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)