| Message ID | 1404919470-26668-4-git-send-email-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, 2014-07-09 at 11:31 -0700, Tadeusz Struk wrote: > On 07/09/2014 08:24 AM, Andy Shevchenko wrote: > > > In this case it slightly changes the output, namely the four tetrads will be > > output on one line. > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > It's ok, I can still read it. It seems I miscalculated the tetrads. It should be 8 per line, correct? In that case we could easily use 32 bytes per line and thus remove that paragraph from commit message. > Acked-by: Tadeusz Struk <tadeusz.struk@intel.com> Thanks!
diff --git a/drivers/crypto/qat/qat_common/adf_transport_debug.c b/drivers/crypto/qat/qat_common/adf_transport_debug.c index 6b69745..8b103cf 100644 --- a/drivers/crypto/qat/qat_common/adf_transport_debug.c +++ b/drivers/crypto/qat/qat_common/adf_transport_debug.c @@ -86,9 +86,7 @@ static int adf_ring_show(struct seq_file *sfile, void *v) { struct adf_etr_ring_data *ring = sfile->private; struct adf_etr_bank_data *bank = ring->bank; - uint32_t *msg = v; void __iomem *csr = ring->bank->csr_addr; - int i, x; if (v == SEQ_START_TOKEN) { int head, tail, empty; @@ -111,18 +109,8 @@ static int adf_ring_show(struct seq_file *sfile, void *v) seq_puts(sfile, "----------- Ring data ------------\n"); return 0; } - seq_printf(sfile, "%p:", msg); - x = 0; - i = 0; - for (; i < (ADF_MSG_SIZE_TO_BYTES(ring->msg_size) >> 2); i++) { - seq_printf(sfile, " %08X", *(msg + i)); - if ((ADF_MSG_SIZE_TO_BYTES(ring->msg_size) >> 2) != i + 1 && - (++x == 8)) { - seq_printf(sfile, "\n%p:", msg + i + 1); - x = 0; - } - } - seq_puts(sfile, "\n"); + seq_hex_dump(sfile, "", DUMP_PREFIX_ADDRESS, 16, 4, + v, ADF_MSG_SIZE_TO_BYTES(ring->msg_size), false); return 0; }
Instead of custom approach let's use recently introduced seq_hex_dump() helper. In this case it slightly changes the output, namely the four tetrads will be output on one line. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/crypto/qat/qat_common/adf_transport_debug.c | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-)