| Message ID | 1404919470-26668-6-git-send-email-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, 2014-07-09 at 18:24 +0300, Andy Shevchenko wrote: > Instead of custom approach let's use recently introduced seq_hex_dump() helper. > > In this case it slightly changes the output, namely the four tetrads will be > output on one line. The above paragraph is not true and will be removed in v2. The output is kept the same as in original code. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/s390/crypto/zcrypt_api.c | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) > > diff --git a/drivers/s390/crypto/zcrypt_api.c b/drivers/s390/crypto/zcrypt_api.c > index 0e18c5d..d1f9983 100644 > --- a/drivers/s390/crypto/zcrypt_api.c > +++ b/drivers/s390/crypto/zcrypt_api.c > @@ -1203,16 +1203,8 @@ static void sprinthx(unsigned char *title, struct seq_file *m, > static void sprinthx4(unsigned char *title, struct seq_file *m, > unsigned int *array, unsigned int len) > { > - int r; > - > seq_printf(m, "\n%s\n", title); > - for (r = 0; r < len; r++) { > - if ((r % 8) == 0) > - seq_printf(m, " "); > - seq_printf(m, "%08X ", array[r]); > - if ((r % 8) == 7) > - seq_putc(m, '\n'); > - } > + seq_hex_dump(m, " ", DUMP_PREFIX_NONE, 32, 4, array, len, false); > seq_putc(m, '\n'); > } >
diff --git a/drivers/s390/crypto/zcrypt_api.c b/drivers/s390/crypto/zcrypt_api.c index 0e18c5d..d1f9983 100644 --- a/drivers/s390/crypto/zcrypt_api.c +++ b/drivers/s390/crypto/zcrypt_api.c @@ -1203,16 +1203,8 @@ static void sprinthx(unsigned char *title, struct seq_file *m, static void sprinthx4(unsigned char *title, struct seq_file *m, unsigned int *array, unsigned int len) { - int r; - seq_printf(m, "\n%s\n", title); - for (r = 0; r < len; r++) { - if ((r % 8) == 0) - seq_printf(m, " "); - seq_printf(m, "%08X ", array[r]); - if ((r % 8) == 7) - seq_putc(m, '\n'); - } + seq_hex_dump(m, " ", DUMP_PREFIX_NONE, 32, 4, array, len, false); seq_putc(m, '\n'); }
Instead of custom approach let's use recently introduced seq_hex_dump() helper. In this case it slightly changes the output, namely the four tetrads will be output on one line. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/s390/crypto/zcrypt_api.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-)