From patchwork Mon Dec 15 19:58:38 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sakari Ailus X-Patchwork-Id: 5497401 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 5B0AF9F1D4 for ; Mon, 15 Dec 2014 19:59:24 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 82F23209EB for ; Mon, 15 Dec 2014 19:59:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A47D4209E5 for ; Mon, 15 Dec 2014 19:59:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751445AbaLOT7U (ORCPT ); Mon, 15 Dec 2014 14:59:20 -0500 Received: from mga01.intel.com ([192.55.52.88]:9172 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751319AbaLOT7U (ORCPT ); Mon, 15 Dec 2014 14:59:20 -0500 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 15 Dec 2014 11:59:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,581,1413270000"; d="scan'208";a="637928114" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by fmsmga001.fm.intel.com with ESMTP; 15 Dec 2014 11:59:18 -0800 Received: from nauris.fi.intel.com (nauris.localdomain [192.168.240.2]) by paasikivi.fi.intel.com (Postfix) with ESMTP id A9D30204E1; Mon, 15 Dec 2014 21:58:47 +0200 (EET) Received: by nauris.fi.intel.com (Postfix, from userid 1000) id 5BEF6200F4; Mon, 15 Dec 2014 21:58:46 +0200 (EET) From: Sakari Ailus To: linux-media@vger.kernel.org Cc: laurent.pinchart@ideasonboard.com Subject: [yavta PATCH v3 1/3] yavta: Implement data_offset support for multi plane buffers Date: Mon, 15 Dec 2014 21:58:38 +0200 Message-Id: <1418673520-31439-2-git-send-email-sakari.ailus@linux.intel.com> X-Mailer: git-send-email 2.1.0.231.g7484e3b In-Reply-To: <1418673520-31439-1-git-send-email-sakari.ailus@linux.intel.com> References: <1418673520-31439-1-git-send-email-sakari.ailus@linux.intel.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Support data_offset for multi plane buffers. Also add an option to write the data in the buffer before data offset (--buffer-prefix). Signed-off-by: Sakari Ailus Acked-by: Laurent Pinchart --- yavta.c | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/yavta.c b/yavta.c index 77e5a41..cf8239b 100644 --- a/yavta.c +++ b/yavta.c @@ -80,6 +80,8 @@ struct device void *pattern[VIDEO_MAX_PLANES]; unsigned int patternsize[VIDEO_MAX_PLANES]; + + bool write_buffer_prefix; }; static bool video_is_mplane(struct device *dev) @@ -1545,14 +1547,21 @@ static void video_save_image(struct device *dev, struct v4l2_buffer *buf, return; for (i = 0; i < dev->num_planes; i++) { + void *data = dev->buffers[buf->index].mem[i]; unsigned int length; - if (video_is_mplane(dev)) + if (video_is_mplane(dev)) { length = buf->m.planes[i].bytesused; - else + + if (!dev->write_buffer_prefix) { + data += buf->m.planes[i].data_offset; + length -= buf->m.planes[i].data_offset; + } + } else { length = buf->bytesused; + } - ret = write(fd, dev->buffers[buf->index].mem[i], length); + ret = write(fd, data, length); if (ret < 0) { printf("write error: %s (%d)\n", strerror(errno), errno); break; @@ -1717,6 +1726,7 @@ static void usage(const char *argv0) printf("-t, --time-per-frame num/denom Set the time per frame (eg. 1/25 = 25 fps)\n"); printf("-u, --userptr Use the user pointers streaming method\n"); printf("-w, --set-control 'ctrl value' Set control 'ctrl' to 'value'\n"); + printf(" --buffer-prefix Write portions of buffer before data_offset\n"); printf(" --buffer-size Buffer size in bytes\n"); printf(" --enum-formats Enumerate formats\n"); printf(" --enum-inputs Enumerate inputs\n"); @@ -1749,10 +1759,12 @@ static void usage(const char *argv0) #define OPT_BUFFER_SIZE 268 #define OPT_PREMULTIPLIED 269 #define OPT_QUEUE_LATE 270 +#define OPT_BUFFER_PREFIX 271 static struct option opts[] = { {"buffer-size", 1, 0, OPT_BUFFER_SIZE}, {"buffer-type", 1, 0, 'B'}, + {"buffer-prefix", 1, 0, OPT_BUFFER_PREFIX}, {"capture", 2, 0, 'c'}, {"check-overrun", 0, 0, 'C'}, {"delay", 1, 0, 'd'}, @@ -2016,6 +2028,8 @@ int main(int argc, char *argv[]) case OPT_USERPTR_OFFSET: userptr_offset = atoi(optarg); break; + case OPT_BUFFER_PREFIX: + dev.write_buffer_prefix = true; default: printf("Invalid option -%c\n", c); printf("Run %s -h for help.\n", argv[0]);