From patchwork Mon Mar 30 23:13:28 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sakari Ailus X-Patchwork-Id: 6126171 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 84E049F2EC for ; Mon, 30 Mar 2015 23:14:25 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id C4D88203DF for ; Mon, 30 Mar 2015 23:14:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E67BA20454 for ; Mon, 30 Mar 2015 23:14:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753472AbbC3XOU (ORCPT ); Mon, 30 Mar 2015 19:14:20 -0400 Received: from nblzone-211-213.nblnetworks.fi ([83.145.211.213]:39052 "EHLO hillosipuli.retiisi.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753280AbbC3XOT (ORCPT ); Mon, 30 Mar 2015 19:14:19 -0400 Received: from lanttu.localdomain (lanttu.localdomain [192.168.5.64]) by hillosipuli.retiisi.org.uk (Postfix) with ESMTP id 7F00860093; Tue, 31 Mar 2015 02:14:12 +0300 (EEST) From: Sakari Ailus To: linux-media@vger.kernel.org, sre@kernel.org Cc: linux-omap@vger.kernel.org, laurent.pinchart@ideasonboard.com, pali.rohar@gmail.com, tony@atomide.com Subject: [PATCH 1/1] omap3isp: Don't pass uninitialised arguments to of_graph_get_next_endpoint() Date: Tue, 31 Mar 2015 02:13:28 +0300 Message-Id: <1427757208-1938-1-git-send-email-sakari.ailus@iki.fi> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <20150330174123.GA2658@earth> References: <20150330174123.GA2658@earth> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP isp_of_parse_nodes() passed an uninitialised prev argument to of_graph_get_next_endpoint(). This is bad, fix it by assigning NULL to it in the initialisation. Signed-off-by: Sakari Ailus Reported-by: Sebastian Reichel Acked-By: Sebastian Reichel --- drivers/media/platform/omap3isp/isp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c index ff8f633..ff51c4f 100644 --- a/drivers/media/platform/omap3isp/isp.c +++ b/drivers/media/platform/omap3isp/isp.c @@ -2338,7 +2338,7 @@ static int isp_of_parse_node(struct device *dev, struct device_node *node, static int isp_of_parse_nodes(struct device *dev, struct v4l2_async_notifier *notifier) { - struct device_node *node; + struct device_node *node = NULL; notifier->subdevs = devm_kcalloc( dev, ISP_MAX_SUBDEVS, sizeof(*notifier->subdevs), GFP_KERNEL);