From patchwork Sun Sep 13 20:57:00 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 7170651 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 08F11BF036 for ; Sun, 13 Sep 2015 20:58:09 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2656920661 for ; Sun, 13 Sep 2015 20:58:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 216ED20660 for ; Sun, 13 Sep 2015 20:58:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755590AbbIMU5u (ORCPT ); Sun, 13 Sep 2015 16:57:50 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:52348 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755477AbbIMU50 (ORCPT ); Sun, 13 Sep 2015 16:57:26 -0400 Received: from avalon.pp.htv.fi (85-23-193-79.bb.dnainternet.fi [85.23.193.79]) by galahad.ideasonboard.com (Postfix) with ESMTPSA id DA26721C61; Sun, 13 Sep 2015 22:55:03 +0200 (CEST) From: Laurent Pinchart To: linux-media@vger.kernel.org Cc: linux-sh@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH 22/32] v4l: vsp1: Make the BRU optional Date: Sun, 13 Sep 2015 23:57:00 +0300 Message-Id: <1442177830-24536-23-git-send-email-laurent.pinchart+renesas@ideasonboard.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <1442177830-24536-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> References: <1442177830-24536-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Not all VSP instances have a BRU on R-Car Gen3, make it optional. For backward compatibility with older DT bindings default to BRU availability on R-Car Gen2. Cc: devicetree@vger.kernel.org Signed-off-by: Laurent Pinchart --- .../devicetree/bindings/media/renesas,vsp1.txt | 3 +++ drivers/media/platform/vsp1/vsp1.h | 1 + drivers/media/platform/vsp1/vsp1_drv.c | 23 ++++++++++++++++------ 3 files changed, 21 insertions(+), 6 deletions(-) diff --git a/Documentation/devicetree/bindings/media/renesas,vsp1.txt b/Documentation/devicetree/bindings/media/renesas,vsp1.txt index 674c8c30d046..766f034c1e45 100644 --- a/Documentation/devicetree/bindings/media/renesas,vsp1.txt +++ b/Documentation/devicetree/bindings/media/renesas,vsp1.txt @@ -20,6 +20,9 @@ Optional properties: - renesas,#uds: Number of Up Down Scaler (UDS) modules in the VSP1. Defaults to 0 if not present. + - renesas,has-bru: Boolean, indicates that the Blending & ROP Unit (BRU) + module is available. Defaults to true on R-Car Gen2 and false on R-Car Gen3 + if not present. - renesas,has-lif: Boolean, indicates that the LCD Interface (LIF) module is available. - renesas,has-lut: Boolean, indicates that the Look Up Table (LUT) module is diff --git a/drivers/media/platform/vsp1/vsp1.h b/drivers/media/platform/vsp1/vsp1.h index 3b2b2387e085..173f9f830049 100644 --- a/drivers/media/platform/vsp1/vsp1.h +++ b/drivers/media/platform/vsp1/vsp1.h @@ -42,6 +42,7 @@ struct vsp1_uds; #define VSP1_HAS_LIF (1 << 0) #define VSP1_HAS_LUT (1 << 1) #define VSP1_HAS_SRU (1 << 2) +#define VSP1_HAS_BRU (1 << 3) struct vsp1_platform_data { unsigned int features; diff --git a/drivers/media/platform/vsp1/vsp1_drv.c b/drivers/media/platform/vsp1/vsp1_drv.c index bd22457bf392..eccdacdf4f4c 100644 --- a/drivers/media/platform/vsp1/vsp1_drv.c +++ b/drivers/media/platform/vsp1/vsp1_drv.c @@ -223,13 +223,15 @@ static int vsp1_create_entities(struct vsp1_device *vsp1) } /* Instantiate all the entities. */ - vsp1->bru = vsp1_bru_create(vsp1); - if (IS_ERR(vsp1->bru)) { - ret = PTR_ERR(vsp1->bru); - goto done; - } + if (vsp1->pdata.features & VSP1_HAS_BRU) { + vsp1->bru = vsp1_bru_create(vsp1); + if (IS_ERR(vsp1->bru)) { + ret = PTR_ERR(vsp1->bru); + goto done; + } - list_add_tail(&vsp1->bru->entity.list_dev, &vsp1->entities); + list_add_tail(&vsp1->bru->entity.list_dev, &vsp1->entities); + } vsp1->hsi = vsp1_hsit_create(vsp1, true); if (IS_ERR(vsp1->hsi)) { @@ -513,6 +515,8 @@ static int vsp1_parse_dt(struct vsp1_device *vsp1) vsp1->info = of_device_get_match_data(vsp1->dev); + if (of_property_read_bool(np, "renesas,has-bru")) + pdata->features |= VSP1_HAS_BRU; if (of_property_read_bool(np, "renesas,has-lif")) pdata->features |= VSP1_HAS_LIF; if (of_property_read_bool(np, "renesas,has-lut")) @@ -542,6 +546,13 @@ static int vsp1_parse_dt(struct vsp1_device *vsp1) return -EINVAL; } + /* Backward compatibility: all Gen2 VSP instances have a BRU, the + * renesas,has-bru property was thus not available. Set the HAS_BRU + * feature automatically in that case. + */ + if (vsp1->info->num_bru_inputs == 4) + pdata->features |= VSP1_HAS_BRU; + return 0; }