From patchwork Fri Feb 26 12:27:12 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 8436451 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 59A979F52D for ; Fri, 26 Feb 2016 12:28:31 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 7F7FB20397 for ; Fri, 26 Feb 2016 12:28:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9F26F20212 for ; Fri, 26 Feb 2016 12:28:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751350AbcBZM2M (ORCPT ); Fri, 26 Feb 2016 07:28:12 -0500 Received: from mout.kundenserver.de ([212.227.126.135]:54172 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751124AbcBZM2L (ORCPT ); Fri, 26 Feb 2016 07:28:11 -0500 Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue002) with ESMTPA (Nemesis) id 0MdifM-1aGXFU2PfQ-00PNkc; Fri, 26 Feb 2016 13:27:36 +0100 From: Arnd Bergmann To: Mauro Carvalho Chehab , Greg Kroah-Hartman Cc: linux-arm-kernel@lists.infradead.org, Arnd Bergmann , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] [media] staging/davinci_vfpe: allow modular build Date: Fri, 26 Feb 2016 13:27:12 +0100 Message-Id: <1456489650-589890-1-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 X-Provags-ID: V03:K0:Lx6VADY/W5bOmnCDPUqwiilGVckSZXEpjXf5Lv7nDeS5XO1SL/h B6rhP+3szC4wya7nW/RRaEdRceWamj4EVRja7knRmQcNf5M7xRkXweOb/ZIH3HzqniJjdVI BE9k+cLs263XUq2z5EmW/f4Wa6BaxcezyOzm0Vd8jek13EbRcjT3IehGCKnJPhwxeFMlO2p vzPH3VfRqCJAuuaE2PgCA== X-UI-Out-Filterresults: notjunk:1; V01:K0:z0/v/XW8G4k=:QKnztscGNjILF2LeFvWlif ZdNWM/YQfTcSmvEqwV+Bdw+IY2skMdt42NTk5g7n9vmf+q0i+RjVTvDbHcYRMxdEtrzN/IpVT RI/yAvszKi+ok7AwiLShdxHT3xsGSVeMMclsRnSmxMKWZjwkrJ4idlPvuORctXD4+TFkUF9jX Uff+T/wnfwD89X1M5cZIMBNxFs+vJwq0LxGqETBmE8as/FJm/03kjvf0jiTf9m4KZvpsHkI80 3xLf5gCKd8WhG9sk2yxikFBW/392r422K44k9zMIqquN790GtaLW90ImNvw3ZuTE+oBxkOUYo JIOrn5iXqL7bp7SUMTaLNOwgXTJa4R119sahkcKIPbPfBtHyg4/3IpDD7Q4xLowJR9oGDPR36 t2EdhonMRpuQIRXmCGvlPr6U8p8j51S9b/iwB5yCNtLl6/xGbIRDrSZ7Mbi/i09/eLwxq3Tmu f0047cnjDCLc+H9+seqU+9d8B7Fmq9BSfgMZZJUiL9kjXkTZ6FtodzA6XUzQI3eyQub4ypGwO REszOTtBW8zvclfxdu9XdTF47Oay5vumXYZ22nci6yBTEushCK0vL3LJzvocGqYC2CBwtTvsb dDQ233Gf9Duk974yeu/I+VvxJxEwQf0NbGMOI9PzU7NIeRoNqZ8PFFjHLMZ7wcNYTWt46F2AX z87+YLKENlugrRufJ7jX1t4xVYo6ljtbWVxWR02TKUzwSgjcivG6MH6tSSBRKo8rSRW8= Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It has never been possible to actually build this driver as a loadable module, only built-in because the Makefile attempts to build each file into its own module and fails: ERROR: "mbus_to_pix" [drivers/staging/media/davinci_vpfe/vpfe_video.ko] undefined! ERROR: "vpfe_resizer_register_entities" [drivers/staging/media/davinci_vpfe/vpfe_mc_capture.ko] undefined! ERROR: "rsz_enable" [drivers/staging/media/davinci_vpfe/dm365_resizer.ko] undefined! ERROR: "config_ipipe_hw" [drivers/staging/media/davinci_vpfe/dm365_ipipe.ko] undefined! ERROR: "ipipe_set_lutdpc_regs" [drivers/staging/media/davinci_vpfe/dm365_ipipe.ko] undefined! It took a long time to catch this bug with randconfig builds because at least 14 other Kconfig symbols have to be enabled in order to configure this one, and it was clearly only ever tested as built-in with mainline kernels, if at all. The solution is really easy: this patch changes the Makefile to link all files into one module. Signed-off-by: Arnd Bergmann --- drivers/staging/media/davinci_vpfe/Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Patch was sent originally on December 10, see http://lkml.iu.edu/hypermail/linux/kernel/1512.1/02383.html It still looks valid to me, and the problem persists without the patch. diff --git a/drivers/staging/media/davinci_vpfe/Makefile b/drivers/staging/media/davinci_vpfe/Makefile index c64515c644cd..3019c9ecd548 100644 --- a/drivers/staging/media/davinci_vpfe/Makefile +++ b/drivers/staging/media/davinci_vpfe/Makefile @@ -1,3 +1,5 @@ -obj-$(CONFIG_VIDEO_DM365_VPFE) += \ +obj-$(CONFIG_VIDEO_DM365_VPFE) += davinci-vfpe.o + +davinci-vfpe-objs := \ dm365_isif.o dm365_ipipe_hw.o dm365_ipipe.o \ dm365_resizer.o dm365_ipipeif.o vpfe_mc_capture.o vpfe_video.o