From patchwork Mon Mar 14 22:40:07 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 8584041 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id C20DDC0553 for ; Mon, 14 Mar 2016 22:41:10 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id AD95D2034B for ; Mon, 14 Mar 2016 22:41:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B9DB72034C for ; Mon, 14 Mar 2016 22:41:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753239AbcCNWku (ORCPT ); Mon, 14 Mar 2016 18:40:50 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:62280 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752763AbcCNWkt (ORCPT ); Mon, 14 Mar 2016 18:40:49 -0400 Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue102) with ESMTPA (Nemesis) id 0MNtBT-1alLfH2CKZ-007QvQ; Mon, 14 Mar 2016 23:40:32 +0100 From: Arnd Bergmann To: Hans Verkuil , Mauro Carvalho Chehab Cc: Arnd Bergmann , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/3] [media] cobalt: add MTD dependency Date: Mon, 14 Mar 2016 23:40:07 +0100 Message-Id: <1457995225-1199991-1-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 X-Provags-ID: V03:K0:vC6foUqOuyDb6+Uca6uTv0pAxqnBL0QAd7prkscaXgDVafJ/+Fb p+SUFAOFGIkULE2EExR2rhFxZ3BtW4TW+xwGm9vqkEKsI5wLIqPLkVcBQ5qwpqrieCq/0ZD hx9sFpPAQtpCiHKs/Q6phDvmsIXZ5rV7xedwpzN6HhxBC52J1rhKUCsmUE4dgysP5YIMX3F 5yWzO74/W64A7tvUMnMNQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:Y0IxHhyf9Ak=:CTJHYedoO/fgVP40cNhnhl rtRqQY6bFhixiy+nwgqYCRHCgxlF4v7DuGkW+OUQHHqFhOSVVPEksqqFvjWl7u5r9zL4yxVwB CfBms79T0nyzSThHJp0EhGT6LcDajfM2p2/km8YJ5Cj/75I4O242p6qCXTRAqbnlEl9xaDujm kNu9DZujbG4Sulx4CZC5q6H3X7jZ0tGMGo9wuxmSCTvZjz/FBqOUzoFPsmY94BtQzvijCUso8 RNPDel1aSXMGr4VDUw5CW0SJg05gytCV0celQ5fpXaRSpgtLk3m6LYf2ZcomKSG4hgR1HnESj 7JlbvTZvScFB3eIW0r1SRePf/CApqQyxD6prnQ9/NSGtUc8e9YibCLNhjYbz/LuzrwWVQ6Afu hM2Kh4NSxbFnFeLGX0l9rj11mhQxLiCugzizuyF0Gnqf8m5NGo0HglNDkzfQ3vCJzGwLt+kPr JRpkoXsKZzHWr5tpXfkc7CSuvYm4WJMdogGBrP/P4rsBtwrMN7N561OeG/xXpBzVFkEbNHd4r gHtvGlBXfnexNvFtrBtrETEL2B0YllN+w0Dzj2NDo6OM+T+mxWwbPqEEyFZhwyOr0nryEFO/d KxVKU8pH/NtNARHSoSMVppWvFTfEy6oHnUpQf9zUiZynEJ+BUG2pjbLMrKJND6XPFjlJxzrmq QQv76WvAYcqtNEJYDVQxA8DYLqu5ysz1rQpLxD7670rGKMnpronS83HXJ7ZkBS9wWEbc= Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The cobalt driver fails to link when it is built-in and MTD is disabled or a loadable module: drivers/media/built-in.o: In function `cobalt_flash_probe': :(.text+0xb8b46): undefined reference to `mtd_device_parse_register' :(.text+0xb8b88): undefined reference to `do_map_probe' drivers/media/built-in.o: In function `cobalt_flash_remove': :(.text+0xb8bb4): undefined reference to `mtd_device_unregister' :(.text+0xb8bbe): undefined reference to `map_destroy' This adds a Kconfig dependency to ensure we can call the API. Signed-off-by: Arnd Bergmann --- drivers/media/pci/cobalt/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/pci/cobalt/Kconfig b/drivers/media/pci/cobalt/Kconfig index a01f0cc745cc..70343829a125 100644 --- a/drivers/media/pci/cobalt/Kconfig +++ b/drivers/media/pci/cobalt/Kconfig @@ -4,6 +4,7 @@ config VIDEO_COBALT depends on PCI_MSI && MTD_COMPLEX_MAPPINGS depends on GPIOLIB || COMPILE_TEST depends on SND + depends on MTD select I2C_ALGOBIT select VIDEO_ADV7604 select VIDEO_ADV7511