From patchwork Wed May 11 13:29:44 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 9069801 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id CE3CCBF29F for ; Wed, 11 May 2016 13:30:43 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D45A220114 for ; Wed, 11 May 2016 13:30:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EF7DA200ED for ; Wed, 11 May 2016 13:30:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932487AbcEKNaW (ORCPT ); Wed, 11 May 2016 09:30:22 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:52077 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932074AbcEKNaV (ORCPT ); Wed, 11 May 2016 09:30:21 -0400 Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue104) with ESMTPA (Nemesis) id 0Leu47-1bP3SV3Lxv-00qhrN; Wed, 11 May 2016 15:30:12 +0200 From: Arnd Bergmann To: Mauro Carvalho Chehab , Greg Kroah-Hartman , Arnd Bergmann Cc: linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH RESEND^3] [media] staging/davinci_vfpe: allow modular build Date: Wed, 11 May 2016 15:29:44 +0200 Message-Id: <1462973405-1254895-1-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 X-Provags-ID: V03:K0:6voVHY/kn0/WMzIMexxKduLuG6mOEoTVfhcFlR6t7s4oHFYsOqU wGlrDrFXInvrwvMKFfvrPOlRvxkGjs9yGwb0SRvA/H3nAp1dRaHysCo29CqxOBsGs3W/Gxi dEdpVE2iYDcZ4igjcLAz7wiZ9uvB8og+KQVKZ+1Ri6c8KymFiCyoemQUzyV08fOffW62Li1 T/b7pXoN3vBPk6GZ5Pqcw== X-UI-Out-Filterresults: notjunk:1; V01:K0:njS31IE0WTY=:Rf+gecrSBQtBg0qVcnOCfV BAAljO5lilzQsXJC+ZnazgTLwlA8KzH7YDVj3JmPiyiIugaCbys4xe6ItiybapG4b9d+b+SBk dQ7iwQKvnjntxA4AepMfbOraSepfRbFPeZVbBOzIwdrsVgc1DylOHXuH3+V3P7fGvc977N+Jn Lk171zKUlow3V7ZIwqse4gthKU/zSNTjgkidohyFJW1sxJVfIDzy4kjVI3GtCX/IXMN7J5uIH 9BfKv+OVpkmZ5jn9Uf74U11OMKltPWz+NNtkf1BFFWahpGhQ4t/zt9sA4fTPRKb6AzLRrJdbH akHFlRLyj/v2GY3YYmWkxWlDmlM5EPdIwoz1h7CxK4+By0jHwTwO/N1Ubp7fY34TOcFgvAUcO BHB8g0i2BTpfuJKP5X771KjvQq7XEI2SRr53UG7vV/iaR9GHRCaETkQpKQ0uMGtLbbFggLbg8 +r3kEx/qfBApMteQS4VNEkamcp8nT2oP5Ox7bwpr/nNlN3IPhTvGg90WpsHW0wDmCZVy5P23x IEZD0qCBUXx7+sTPZrWjfAQBenOcqw+wGlUT8nrNgZMp9u8tQygLLMqbnHFi7sdY1uc3LLy2H HvJJM+oWQ9cHbmnLBr7Egj9+qDDifthqI1G3WfxJqNO72iprkY2zqrqHcNzhUa1gNyNetft72 u9e3VEXg/Ifh/9RoTzGm8HTYTFqfAcwU5rtcOR87nWVWcRJSD7zhAr/4ySo+tw8xAPHg= Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It has never been possible to actually build this driver as a loadable module, only built-in because the Makefile attempts to build each file into its own module and fails: ERROR: "mbus_to_pix" [drivers/staging/media/davinci_vpfe/vpfe_video.ko] undefined! ERROR: "vpfe_resizer_register_entities" [drivers/staging/media/davinci_vpfe/vpfe_mc_capture.ko] undefined! ERROR: "rsz_enable" [drivers/staging/media/davinci_vpfe/dm365_resizer.ko] undefined! ERROR: "config_ipipe_hw" [drivers/staging/media/davinci_vpfe/dm365_ipipe.ko] undefined! ERROR: "ipipe_set_lutdpc_regs" [drivers/staging/media/davinci_vpfe/dm365_ipipe.ko] undefined! It took a long time to catch this bug with randconfig builds because at least 14 other Kconfig symbols have to be enabled in order to configure this one, and it was clearly only ever tested as built-in with mainline kernels, if at all. The solution is really easy: this patch changes the Makefile to link all files into one module. As discussed previously, the driver has never before used successfully as a loadable module, but there is no reason to prevent that configuration. Signed-off-by: Arnd Bergmann Link: http://lkml.iu.edu/hypermail/linux/kernel/1512.1/02383.html --- I keep running into this bug roughly every 10000 randconfig builds, please apply the fix. drivers/staging/media/davinci_vpfe/Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/davinci_vpfe/Makefile b/drivers/staging/media/davinci_vpfe/Makefile index c64515c644cd..3019c9ecd548 100644 --- a/drivers/staging/media/davinci_vpfe/Makefile +++ b/drivers/staging/media/davinci_vpfe/Makefile @@ -1,3 +1,5 @@ -obj-$(CONFIG_VIDEO_DM365_VPFE) += \ +obj-$(CONFIG_VIDEO_DM365_VPFE) += davinci-vfpe.o + +davinci-vfpe-objs := \ dm365_isif.o dm365_ipipe_hw.o dm365_ipipe.o \ dm365_resizer.o dm365_ipipeif.o vpfe_mc_capture.o vpfe_video.o