diff mbox

[3/3] dt-bindings: Add Renesas R-Car FDP1 bindings

Message ID 1465479695-18644-4-git-send-email-kieran@bingham.xyz (mailing list archive)
State New, archived
Headers show

Commit Message

Kieran Bingham June 9, 2016, 1:41 p.m. UTC
The FDP1 is a de-interlacing module which converts interlaced video to
progressive video. It is also capable of performing pixel format conversion
between YCbCr/YUV formats and RGB formats.

Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
---
 .../devicetree/bindings/media/renesas,fdp1.txt     | 34 ++++++++++++++++++++++
 1 file changed, 34 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/renesas,fdp1.txt

Comments

Rob Herring (Arm) June 10, 2016, 5:40 p.m. UTC | #1
On Thu, Jun 09, 2016 at 02:41:34PM +0100, Kieran Bingham wrote:
> The FDP1 is a de-interlacing module which converts interlaced video to
> progressive video. It is also capable of performing pixel format conversion
> between YCbCr/YUV formats and RGB formats.
> 
> Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
> ---
>  .../devicetree/bindings/media/renesas,fdp1.txt     | 34 ++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/renesas,fdp1.txt
> 
> diff --git a/Documentation/devicetree/bindings/media/renesas,fdp1.txt b/Documentation/devicetree/bindings/media/renesas,fdp1.txt
> new file mode 100644
> index 000000000000..e2da2aec5e9f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/renesas,fdp1.txt
> @@ -0,0 +1,34 @@
> +Renesas R-Car Fine Display Processor (FDP1)
> +-----------------------------------------------
> +
> +The FDP1 is a de-interlacing module which converts interlaced video to
> +progressive video. It is capable of performing pixel format conversion between
> +YCbCr/YUV formats and RGB formats. Only YCbCr/YUV formats are supported as
> +an input to the module.
> +
> + - compatible: Must be one or more of the following
> +
> +   - "renesas,r8a7795-fdp1" for R8A7795 (R-Car H3)
> +   - "renesas,r8a7796-fdp1" for R8A7796 (R-Car M3-W)
> +   - "renesas,fdp1" for generic compatible
> +
> +   When compatible with the generic version, nodes must list the
> +   SoC-specific version corresponding to the platform first, followed by the
> +   family-specific and/or generic versions.
> +
> + - reg: the register base and size for the device registers
> + - clocks: Reference to the functional clock
> + - renesas,fcp: Reference to the FCPF connected to the FDP1
> +
> +
> +Device node example
> +-------------------
> +
> +	fdp1ch1: fdp1@fe940000 {
> +		compatible = "renesas,r8a7795-fdp1", "renesas,fdp1";
> +		reg = <0 0xfe940000 0 0x2400>;
> +		interrupts = <GIC_SPI 262 IRQ_TYPE_LEVEL_HIGH>;
> +		clocks = <&cpg CPG_MOD 119>;
> +		power-domains = <&sysc R8A7795_PD_A3VP>;

Not documented.

> +		renesas,fcp = <&fcpf0>;
> +	};
> \ No newline at end of file

Fix this.

> -- 
> 2.7.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Kieran Bingham June 13, 2016, 11:31 a.m. UTC | #2
On 10/06/16 18:40, Rob Herring wrote:
> On Thu, Jun 09, 2016 at 02:41:34PM +0100, Kieran Bingham wrote:
>> The FDP1 is a de-interlacing module which converts interlaced video to
>> progressive video. It is also capable of performing pixel format conversion
>> between YCbCr/YUV formats and RGB formats.
>>
>> Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
>> ---
>>  .../devicetree/bindings/media/renesas,fdp1.txt     | 34 ++++++++++++++++++++++
>>  1 file changed, 34 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/media/renesas,fdp1.txt
>>
>> diff --git a/Documentation/devicetree/bindings/media/renesas,fdp1.txt b/Documentation/devicetree/bindings/media/renesas,fdp1.txt
>> new file mode 100644
>> index 000000000000..e2da2aec5e9f
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/media/renesas,fdp1.txt
>> @@ -0,0 +1,34 @@
>> +Renesas R-Car Fine Display Processor (FDP1)
>> +-----------------------------------------------
>> +
>> +The FDP1 is a de-interlacing module which converts interlaced video to
>> +progressive video. It is capable of performing pixel format conversion between
>> +YCbCr/YUV formats and RGB formats. Only YCbCr/YUV formats are supported as
>> +an input to the module.
>> +
>> + - compatible: Must be one or more of the following
>> +
>> +   - "renesas,r8a7795-fdp1" for R8A7795 (R-Car H3)
>> +   - "renesas,r8a7796-fdp1" for R8A7796 (R-Car M3-W)
>> +   - "renesas,fdp1" for generic compatible
>> +
>> +   When compatible with the generic version, nodes must list the
>> +   SoC-specific version corresponding to the platform first, followed by the
>> +   family-specific and/or generic versions.
>> +
>> + - reg: the register base and size for the device registers
>> + - clocks: Reference to the functional clock
>> + - renesas,fcp: Reference to the FCPF connected to the FDP1
>> +
>> +
>> +Device node example
>> +-------------------
>> +
>> +	fdp1ch1: fdp1@fe940000 {
>> +		compatible = "renesas,r8a7795-fdp1", "renesas,fdp1";
>> +		reg = <0 0xfe940000 0 0x2400>;
>> +		interrupts = <GIC_SPI 262 IRQ_TYPE_LEVEL_HIGH>;
>> +		clocks = <&cpg CPG_MOD 119>;
>> +		power-domains = <&sysc R8A7795_PD_A3VP>;
> 
> Not documented.

I'll mirror whatever the consensus is on this topic from the other patch
here.

> 
>> +		renesas,fcp = <&fcpf0>;
>> +	};
>> \ No newline at end of file
> 
> Fix this.

Ok

>> -- 
>> 2.7.4
>>
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/media/renesas,fdp1.txt b/Documentation/devicetree/bindings/media/renesas,fdp1.txt
new file mode 100644
index 000000000000..e2da2aec5e9f
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/renesas,fdp1.txt
@@ -0,0 +1,34 @@ 
+Renesas R-Car Fine Display Processor (FDP1)
+-----------------------------------------------
+
+The FDP1 is a de-interlacing module which converts interlaced video to
+progressive video. It is capable of performing pixel format conversion between
+YCbCr/YUV formats and RGB formats. Only YCbCr/YUV formats are supported as
+an input to the module.
+
+ - compatible: Must be one or more of the following
+
+   - "renesas,r8a7795-fdp1" for R8A7795 (R-Car H3)
+   - "renesas,r8a7796-fdp1" for R8A7796 (R-Car M3-W)
+   - "renesas,fdp1" for generic compatible
+
+   When compatible with the generic version, nodes must list the
+   SoC-specific version corresponding to the platform first, followed by the
+   family-specific and/or generic versions.
+
+ - reg: the register base and size for the device registers
+ - clocks: Reference to the functional clock
+ - renesas,fcp: Reference to the FCPF connected to the FDP1
+
+
+Device node example
+-------------------
+
+	fdp1ch1: fdp1@fe940000 {
+		compatible = "renesas,r8a7795-fdp1", "renesas,fdp1";
+		reg = <0 0xfe940000 0 0x2400>;
+		interrupts = <GIC_SPI 262 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&cpg CPG_MOD 119>;
+		power-domains = <&sysc R8A7795_PD_A3VP>;
+		renesas,fcp = <&fcpf0>;
+	};
\ No newline at end of file