| Message ID | 1467206444-9935-16-git-send-email-andi.shyti@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Jun 29, 2016 at 10:20:44PM +0900, Andi Shyti wrote: > The Lirc framework works mainly with receivers, but there is > nothing that prevents us from using it for transmitters as well. The lirc interface already provides for transmitting IR. > For that we need to have more control on the device frequency to > set (which is a new concept fro LIRC) and we also need to provide > to userspace, as feedback, the values of the used frequency and > length. Please can you elaborate on what exactly you mean by frequency and length. The carrier frequency can already be set with LIRC_SET_SEND_CARRIER. > Add the LIRC_SET_LENGTH, LIRC_GET_FREQUENCY and > LIRC_SET_FREQUENCY ioctl commands in order to allow the above > mentioned operations. You're also adding ioctls without any drivers implementing them unless I missed something. > > Signed-off-by: Andi Shyti <andi.shyti@samsung.com> > --- > include/uapi/linux/lirc.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/include/uapi/linux/lirc.h b/include/uapi/linux/lirc.h > index 4b3ab29..94a0d8c 100644 > --- a/include/uapi/linux/lirc.h > +++ b/include/uapi/linux/lirc.h > @@ -106,6 +106,7 @@ > > /* code length in bits, currently only for LIRC_MODE_LIRCCODE */ > #define LIRC_GET_LENGTH _IOR('i', 0x0000000f, __u32) > +#define LIRC_SET_LENGTH _IOW('i', 0x00000010, __u32) The LIRC_GET_LENGTH is specific to LIRCCODE encoding. Why are you adding it here? > > #define LIRC_SET_SEND_MODE _IOW('i', 0x00000011, __u32) > #define LIRC_SET_REC_MODE _IOW('i', 0x00000012, __u32) > @@ -165,4 +166,7 @@ > > #define LIRC_SET_WIDEBAND_RECEIVER _IOW('i', 0x00000023, __u32) > > +#define LIRC_GET_FREQUENCY _IOR('i', 0x00000024, __u32) > +#define LIRC_SET_FREQUENCY _IOW('i', 0x00000025, __u32) > + > #endif > -- > 2.8.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Sean, > > For that we need to have more control on the device frequency to > > set (which is a new concept fro LIRC) and we also need to provide > > to userspace, as feedback, the values of the used frequency and > > length. > > Please can you elaborate on what exactly you mean by frequency and > length. > > The carrier frequency can already be set with LIRC_SET_SEND_CARRIER. yes, I mean carrier's frequency. I didn't understand that LIRC_SET_SEND_CARRIER was related to the frequency. > > Add the LIRC_SET_LENGTH, LIRC_GET_FREQUENCY and > > LIRC_SET_FREQUENCY ioctl commands in order to allow the above > > mentioned operations. > > You're also adding ioctls without any drivers implementing them > unless I missed something. You're right; the first idea was to submit also the device driver, but then I decided to keep it separate from this patchset. Anyway, we can drop this one (it's the last of the series) and, in case it will be needed after the above comment, I will re-send it with the driver. Thanks, Andi -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/uapi/linux/lirc.h b/include/uapi/linux/lirc.h index 4b3ab29..94a0d8c 100644 --- a/include/uapi/linux/lirc.h +++ b/include/uapi/linux/lirc.h @@ -106,6 +106,7 @@ /* code length in bits, currently only for LIRC_MODE_LIRCCODE */ #define LIRC_GET_LENGTH _IOR('i', 0x0000000f, __u32) +#define LIRC_SET_LENGTH _IOW('i', 0x00000010, __u32) #define LIRC_SET_SEND_MODE _IOW('i', 0x00000011, __u32) #define LIRC_SET_REC_MODE _IOW('i', 0x00000012, __u32) @@ -165,4 +166,7 @@ #define LIRC_SET_WIDEBAND_RECEIVER _IOW('i', 0x00000023, __u32) +#define LIRC_GET_FREQUENCY _IOR('i', 0x00000024, __u32) +#define LIRC_SET_FREQUENCY _IOW('i', 0x00000025, __u32) + #endif
The Lirc framework works mainly with receivers, but there is nothing that prevents us from using it for transmitters as well. For that we need to have more control on the device frequency to set (which is a new concept fro LIRC) and we also need to provide to userspace, as feedback, the values of the used frequency and length. Add the LIRC_SET_LENGTH, LIRC_GET_FREQUENCY and LIRC_SET_FREQUENCY ioctl commands in order to allow the above mentioned operations. Signed-off-by: Andi Shyti <andi.shyti@samsung.com> --- include/uapi/linux/lirc.h | 4 ++++ 1 file changed, 4 insertions(+)