From patchwork Tue Jul 12 17:28:30 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shuah Khan X-Patchwork-Id: 9225803 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0C85F60868 for ; Tue, 12 Jul 2016 17:28:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EE76627C39 for ; Tue, 12 Jul 2016 17:28:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E162B27165; Tue, 12 Jul 2016 17:28:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B6DA527165 for ; Tue, 12 Jul 2016 17:28:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751514AbcGLR2e (ORCPT ); Tue, 12 Jul 2016 13:28:34 -0400 Received: from resqmta-po-06v.sys.comcast.net ([96.114.154.165]:35574 "EHLO resqmta-po-06v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751014AbcGLR2d (ORCPT ); Tue, 12 Jul 2016 13:28:33 -0400 Received: from resomta-po-19v.sys.comcast.net ([96.114.154.243]) by resqmta-po-06v.sys.comcast.net with SMTP id N1U0bxeggBNj9N1U0bCPAd; Tue, 12 Jul 2016 17:28:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20140121; t=1468344512; bh=bvr+5CIL6hfFxj33xlT1gRJ/avhmgeFQ5T/Ls8f5wOA=; h=Received:Received:Received:From:To:Subject:Date:Message-Id; b=vcElzHy+lOY1JhA0mOh4pb95FvqJo02j7w3gr5ZJOzFvjVhFeAZZaNpJOIiDv427L K2RtIzb/bYYKTX745IJXwaYRSKC049nR6gecOrPO7JqzoIfk/uztjacYf8iCbdmi5Y frh3U98Gp1ApskCFNg0/YmlXmufpUJv2VLRFKSpdu+rxaNMnAszjoiZx4PStf3z0Lc Oft3zFoB9gNRPtlg6rK0cOvDwRVUBHds+C6iZNLtIWax5WO1nS3ZTteO51pmWDd5zs eZRQbx9feuPueY/KlKpDzFYJ4BtfAA4wPd3Jpawca6rBdXutRI3WGj0n2oVkiFRtY3 cGtdYjfSTXQ6w== Received: from mail.gonehiking.org ([73.181.52.62]) by comcast with SMTP id N1Tzbsh19IePNN1Tzbpi2C; Tue, 12 Jul 2016 17:28:32 +0000 Received: from shuah-XPS-13-9350.sisa.samsung.com (shuah-xps.internal [192.168.1.87]) by mail.gonehiking.org (Postfix) with ESMTP id 3D5DA9F35B; Tue, 12 Jul 2016 11:28:31 -0600 (MDT) From: Shuah Khan To: kyungmin.park@samsung.com, k.debski@samsung.com, jtp.park@samsung.com, mchehab@kernel.org, javier@osg.samsung.com Cc: Shuah Khan , joe@perches.com, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] media: s5p-mfc Fix misspelled error message and checkpatch errors Date: Tue, 12 Jul 2016 11:28:30 -0600 Message-Id: <1468344510-32411-1-git-send-email-shuahkh@osg.samsung.com> X-Mailer: git-send-email 2.7.4 X-CMAE-Envelope: MS4wfHn9ZkoDyUJVKgi7qbLElseyeEoYWZdDXU8EJcRUIXqkB+d4iAsmV+IEt0dBK3vjbMrmrnIHcFo65bsWcPXBgGVmYSjjyxo7uscqyab5/9bPpk9fOC7U KUMlEmWJZGbhNchZ8Ryd7+O5t0yD7eRytjVzIe3Y9UleNwtVdqyRHJx9zofOH//2XPi+Uv01uAJh+JBXPxB6OqB6xNzKhT+0K69yGs1qRW03kQ9oQoQWupta hf2l4ZKBG/V3QujvRoT1YK9z+qSSGqyQkZsmzuN4Lo9sDjUWEeNAYELfhTC0XH9ourgaYiqCo15YqP/e6O8brDBOpmP2Yx0OL/t9E/4KtXx0xmj42vJ5h0OZ 1jIvHXSHxgLDVsBBOEAQt0Wk7i+ssuvXVaAAWIJe30GlLQbEOXD5iKyqOED7lH4ulX1G8EuWAK1FPS0V4tKlqRpsWozEU7z/VtOILsEemdATRPxZHwbq9wfC e4PSHFhQn2nmQbd3N1ftCdpOjXgd/mJOCD0aX2zEPscXMMnHK6FqTMq+o0s= Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Fix misspelled error message and existing checkpatch errors in the error message conditional. WARNING: suspect code indent for conditional statements (8, 24) if (ctx->state != MFCINST_HEAD_PARSED && [...] mfc_err("Can not get crop information\n"); Signed-off-by: Shuah Khan Reviewed-by: Javier Martinez Canillas --- Changes since v1: - Addressed review comments from Joe Perches - Added reviewed by tag from Javier Martinez Canillas drivers/media/platform/s5p-mfc/s5p_mfc_dec.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c index a01a373..0a9e8d1 100644 --- a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c @@ -775,11 +775,12 @@ static int vidioc_g_crop(struct file *file, void *priv, u32 left, right, top, bottom; if (ctx->state != MFCINST_HEAD_PARSED && - ctx->state != MFCINST_RUNNING && ctx->state != MFCINST_FINISHING - && ctx->state != MFCINST_FINISHED) { - mfc_err("Cannont set crop\n"); - return -EINVAL; - } + ctx->state != MFCINST_RUNNING && + ctx->state != MFCINST_FINISHING && + ctx->state != MFCINST_FINISHED) { + mfc_err("Can not get crop information\n"); + return -EINVAL; + } if (ctx->src_fmt->fourcc == V4L2_PIX_FMT_H264) { left = s5p_mfc_hw_call(dev->mfc_ops, get_crop_info_h, ctx); right = left >> S5P_FIMV_SHARED_CROP_RIGHT_SHIFT;