From patchwork Mon Mar 20 14:39:56 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Cox X-Patchwork-Id: 9634363 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id CD660601E9 for ; Mon, 20 Mar 2017 14:54:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B478828454 for ; Mon, 20 Mar 2017 14:54:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A94402843C; Mon, 20 Mar 2017 14:54:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3C3F827F07 for ; Mon, 20 Mar 2017 14:54:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754635AbdCTOxa (ORCPT ); Mon, 20 Mar 2017 10:53:30 -0400 Received: from mga01.intel.com ([192.55.52.88]:22683 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754843AbdCTOw4 (ORCPT ); Mon, 20 Mar 2017 10:52:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490021575; x=1521557575; h=subject:from:to:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=ZY31/EbECLHld2+CdIoOx1Am8NJvGU2ktYq9kE0RV5M=; b=ElikZo1gzcf99nnWQZHe/Xw+glZ6+ChPJg8+xMySHHdw9Zqy0Epbdx88 frehlIs/+SiFB7G3AZFz1d3DKxETKQ==; Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Mar 2017 07:39:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,194,1486454400"; d="scan'208";a="78428811" Received: from acox1-desk1.ger.corp.intel.com ([10.252.22.109]) by fmsmga005.fm.intel.com with ESMTP; 20 Mar 2017 07:39:57 -0700 Subject: [PATCH 07/24] ov5693: remove unused function From: Alan Cox To: greg@kroah.com, linux-media@vger.kernel.org Date: Mon, 20 Mar 2017 14:39:56 +0000 Message-ID: <149002078811.17109.12866139241727781113.stgit@acox1-desk1.ger.corp.intel.com> In-Reply-To: <149002068431.17109.1216139691005241038.stgit@acox1-desk1.ger.corp.intel.com> References: <149002068431.17109.1216139691005241038.stgit@acox1-desk1.ger.corp.intel.com> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It's commented out in the tree with a note saying to remove it. So let's remove it. Signed-off-by: Alan Cox --- drivers/staging/media/atomisp/i2c/ov5693/ov5693.c | 23 --------------------- 1 file changed, 23 deletions(-) diff --git a/drivers/staging/media/atomisp/i2c/ov5693/ov5693.c b/drivers/staging/media/atomisp/i2c/ov5693/ov5693.c index ac75982..5e9dafe 100644 --- a/drivers/staging/media/atomisp/i2c/ov5693/ov5693.c +++ b/drivers/staging/media/atomisp/i2c/ov5693/ov5693.c @@ -82,30 +82,7 @@ static int vcm_ad_i2c_wr8(struct i2c_client *client, u8 reg, u8 val) } return 0; } -/*TODO: remove this unuseful i2c writer helper*/ -/* -static int vcm_ad_i2c_wr16(struct i2c_client *client, u8 reg, u16 val) -{ - int err; - struct i2c_msg msg; - u8 buf[3]; - buf[0] = reg; - buf[1] = (u8)(val >> 8); - buf[2] = (u8)(val & 0xff); - msg.addr = VCM_ADDR; - msg.flags = 0; - msg.len = 3; - msg.buf = &buf[0]; - err = i2c_transfer(client->adapter, &msg, 1); - if (err != 1) { - dev_err(&client->dev, "%s: vcm i2c fail, err code = %d\n", - __func__, err); - return -EIO; - } - return 0; -} -*/ static int ad5823_i2c_write(struct i2c_client *client, u8 reg, u8 val) { struct i2c_msg msg;