| Message ID | 1511874084-5068-1-git-send-email-geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Geert, Thanks for your patch. On 2017-11-28 14:01:24 +0100, Geert Uytterhoeven wrote: > As of_node_full_name() now returns only the basename, the endpoint > information printed became useless: > > adv748x 4-0070: Endpoint endpoint on port 7 > adv748x 4-0070: Endpoint endpoint on port 8 > adv748x 4-0070: Endpoint endpoint on port 10 > adv748x 4-0070: Endpoint endpoint on port 11 > > Restore the old behavior by using "%pOF" instead: > > adv748x 4-0070: Endpoint /soc/i2c@e66d8000/video-receiver@70/port@7/endpoint on port 7 > adv748x 4-0070: Endpoint /soc/i2c@e66d8000/video-receiver@70/port@8/endpoint on port 8 > adv748x 4-0070: Endpoint /soc/i2c@e66d8000/video-receiver@70/port@10/endpoint on port 10 > adv748x 4-0070: Endpoint /soc/i2c@e66d8000/video-receiver@70/port@11/endpoint on port 11 > > Fixes: a7e4cfb0a7ca4773 ("of/fdt: only store the device node basename in full_name") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > --- > drivers/media/i2c/adv748x/adv748x-core.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/media/i2c/adv748x/adv748x-core.c b/drivers/media/i2c/adv748x/adv748x-core.c > index 5ee14f2c27478e3a..c1001db6a172e256 100644 > --- a/drivers/media/i2c/adv748x/adv748x-core.c > +++ b/drivers/media/i2c/adv748x/adv748x-core.c > @@ -646,14 +646,12 @@ static int adv748x_parse_dt(struct adv748x_state *state) > > for_each_endpoint_of_node(state->dev->of_node, ep_np) { > of_graph_parse_endpoint(ep_np, &ep); > - adv_info(state, "Endpoint %s on port %d", > - of_node_full_name(ep.local_node), > - ep.port); > + adv_info(state, "Endpoint %pOF on port %d", ep.local_node, > + ep.port); > > if (ep.port >= ADV748X_PORT_MAX) { > - adv_err(state, "Invalid endpoint %s on port %d", > - of_node_full_name(ep.local_node), > - ep.port); > + adv_err(state, "Invalid endpoint %pOF on port %d", > + ep.local_node, ep.port); > > continue; > } > -- > 2.7.4 >
Hi Geert, Thanks for the patch. On 28/11/17 13:01, Geert Uytterhoeven wrote: > As of_node_full_name() now returns only the basename, the endpoint > information printed became useless: > > adv748x 4-0070: Endpoint endpoint on port 7 > adv748x 4-0070: Endpoint endpoint on port 8 > adv748x 4-0070: Endpoint endpoint on port 10 > adv748x 4-0070: Endpoint endpoint on port 11 > > Restore the old behavior by using "%pOF" instead: > > adv748x 4-0070: Endpoint /soc/i2c@e66d8000/video-receiver@70/port@7/endpoint on port 7 > adv748x 4-0070: Endpoint /soc/i2c@e66d8000/video-receiver@70/port@8/endpoint on port 8 > adv748x 4-0070: Endpoint /soc/i2c@e66d8000/video-receiver@70/port@10/endpoint on port 10 > adv748x 4-0070: Endpoint /soc/i2c@e66d8000/video-receiver@70/port@11/endpoint on port 11 > > Fixes: a7e4cfb0a7ca4773 ("of/fdt: only store the device node basename in full_name") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > --- > drivers/media/i2c/adv748x/adv748x-core.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/media/i2c/adv748x/adv748x-core.c b/drivers/media/i2c/adv748x/adv748x-core.c > index 5ee14f2c27478e3a..c1001db6a172e256 100644 > --- a/drivers/media/i2c/adv748x/adv748x-core.c > +++ b/drivers/media/i2c/adv748x/adv748x-core.c > @@ -646,14 +646,12 @@ static int adv748x_parse_dt(struct adv748x_state *state) > > for_each_endpoint_of_node(state->dev->of_node, ep_np) { > of_graph_parse_endpoint(ep_np, &ep); > - adv_info(state, "Endpoint %s on port %d", > - of_node_full_name(ep.local_node), > - ep.port); > + adv_info(state, "Endpoint %pOF on port %d", ep.local_node, > + ep.port); > > if (ep.port >= ADV748X_PORT_MAX) { > - adv_err(state, "Invalid endpoint %s on port %d", > - of_node_full_name(ep.local_node), > - ep.port); > + adv_err(state, "Invalid endpoint %pOF on port %d", > + ep.local_node, ep.port); > > continue; > } >
diff --git a/drivers/media/i2c/adv748x/adv748x-core.c b/drivers/media/i2c/adv748x/adv748x-core.c index 5ee14f2c27478e3a..c1001db6a172e256 100644 --- a/drivers/media/i2c/adv748x/adv748x-core.c +++ b/drivers/media/i2c/adv748x/adv748x-core.c @@ -646,14 +646,12 @@ static int adv748x_parse_dt(struct adv748x_state *state) for_each_endpoint_of_node(state->dev->of_node, ep_np) { of_graph_parse_endpoint(ep_np, &ep); - adv_info(state, "Endpoint %s on port %d", - of_node_full_name(ep.local_node), - ep.port); + adv_info(state, "Endpoint %pOF on port %d", ep.local_node, + ep.port); if (ep.port >= ADV748X_PORT_MAX) { - adv_err(state, "Invalid endpoint %s on port %d", - of_node_full_name(ep.local_node), - ep.port); + adv_err(state, "Invalid endpoint %pOF on port %d", + ep.local_node, ep.port); continue; }
As of_node_full_name() now returns only the basename, the endpoint information printed became useless: adv748x 4-0070: Endpoint endpoint on port 7 adv748x 4-0070: Endpoint endpoint on port 8 adv748x 4-0070: Endpoint endpoint on port 10 adv748x 4-0070: Endpoint endpoint on port 11 Restore the old behavior by using "%pOF" instead: adv748x 4-0070: Endpoint /soc/i2c@e66d8000/video-receiver@70/port@7/endpoint on port 7 adv748x 4-0070: Endpoint /soc/i2c@e66d8000/video-receiver@70/port@8/endpoint on port 8 adv748x 4-0070: Endpoint /soc/i2c@e66d8000/video-receiver@70/port@10/endpoint on port 10 adv748x 4-0070: Endpoint /soc/i2c@e66d8000/video-receiver@70/port@11/endpoint on port 11 Fixes: a7e4cfb0a7ca4773 ("of/fdt: only store the device node basename in full_name") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/media/i2c/adv748x/adv748x-core.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)