From patchwork Wed May 2 21:46:18 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brad Love X-Patchwork-Id: 10376691 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id EFDFA603B4 for ; Wed, 2 May 2018 21:57:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D6D05292CD for ; Wed, 2 May 2018 21:57:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9D18729EC2; Wed, 2 May 2018 21:55:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 378912A4BE for ; Wed, 2 May 2018 21:46:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751544AbeEBVqi (ORCPT ); Wed, 2 May 2018 17:46:38 -0400 Received: from sub5.mail.dreamhost.com ([208.113.200.129]:34011 "EHLO homiemail-a80.g.dreamhost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750970AbeEBVqh (ORCPT ); Wed, 2 May 2018 17:46:37 -0400 Received: from homiemail-a80.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a80.g.dreamhost.com (Postfix) with ESMTP id 766D6E00080B; Wed, 2 May 2018 14:46:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=nextdimension.cc; h=from :to:cc:subject:date:message-id; s=nextdimension.cc; bh=ClWuPwe56 FZJcVb3g1+MO5AE0q8=; b=cGbHdUeFhhqAAVPIfxWzKHSQWyU2fiml47beGqlph 6ppS4pWzzXte15v5jvn/tkjtOy/EjdXkeDd8e9vmq+QYJYXFNUda/FNtCyDEC1t7 SnaQyb1fSRgQzenCQMCH23194OoGOUPKXNUsSljzlmlnlj6LdqBAkDzm/Ihg1Juw yA= Received: from localhost.localdomain (66-90-189-166.dyn.grandenetworks.net [66.90.189.166]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: brad@nextdimension.ws) by homiemail-a80.g.dreamhost.com (Postfix) with ESMTPSA id 1BF24E00080A; Wed, 2 May 2018 14:46:31 -0700 (PDT) From: Brad Love To: linux-media@vger.kernel.org, mchehab@s-opensource.com Cc: Brad Love Subject: [PATCH] [BUG] em28xx: Fix DualHD broken second tuner Date: Wed, 2 May 2018 16:46:18 -0500 Message-Id: <1525297578-28250-1-git-send-email-brad@nextdimension.cc> X-Mailer: git-send-email 2.7.4 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The use of a hard coded i2c address breaks the creation of the second tuner in DualHD 01595 models. The issue is compounded by lack of any error message stating that a driver failed initialization. Use addr, which contains the correct address for each tuner. Fixes: ad32495b1513 ("media: em28xx-dvb: simplify DVB module probing logic") Signed-off-by: Brad Love --- drivers/media/usb/em28xx/em28xx-dvb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/em28xx/em28xx-dvb.c b/drivers/media/usb/em28xx/em28xx-dvb.c index a54cb8d..4ab71a2 100644 --- a/drivers/media/usb/em28xx/em28xx-dvb.c +++ b/drivers/media/usb/em28xx/em28xx-dvb.c @@ -1392,7 +1392,7 @@ static int em28174_dvb_init_hauppauge_wintv_dualhd_01595(struct em28xx *dev) dvb->i2c_client_tuner = dvb_module_probe("si2157", NULL, adapter, - 0x60, &si2157_config); + addr, &si2157_config); if (!dvb->i2c_client_tuner) { dvb_module_release(dvb->i2c_client_demod); return -ENODEV;