From patchwork Wed Jan 14 16:20:04 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mauro Carvalho Chehab X-Patchwork-Id: 2342 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n0EGH4W6027144 for ; Wed, 14 Jan 2009 08:17:04 -0800 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757195AbZANQUo (ORCPT ); Wed, 14 Jan 2009 11:20:44 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1763989AbZANQUn (ORCPT ); Wed, 14 Jan 2009 11:20:43 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:37311 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763995AbZANQUn (ORCPT ); Wed, 14 Jan 2009 11:20:43 -0500 Received: from 200.220.139.66.nipcable.com ([200.220.139.66] helo=pedra.chehab.org) by bombadil.infradead.org with esmtpsa (Exim 4.69 #1 (Red Hat Linux)) id 1LN8Tq-0004xA-Cp; Wed, 14 Jan 2009 16:20:34 +0000 Date: Wed, 14 Jan 2009 14:20:04 -0200 From: Mauro Carvalho Chehab To: Mike Isely Cc: isely@isely.net, linux-media@vger.kernel.org, Hans Verkuil Subject: Re: [PULL] http://linuxtv.org/hg/~mcisely/pvrusb2 Message-ID: <20090114142004.0833d61d@pedra.chehab.org> In-Reply-To: References: X-Mailer: Claws Mail 3.3.1 (GTK+ 2.10.4; x86_64-redhat-linux-gnu) Mime-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Wed, 14 Jan 2009 08:52:09 -0600 (CST) Mike Isely wrote: > > Mauro: > > Please pull from http://linuxtv.org/hg/~mcisely/pvrusb2 for: > About this changeset: > - pvrusb2: Report device serial number in bus-info field Previously the V4L bus-info capability reported USB address, a fairly useless thing for anyone but a USB core maintainer (IMHO). This change replaces that information with the device's serial number if possible, or otherwise a unit number. Priority: normal Signed-off-by: Mike Isely I can see some troubles here: 1) The bus info helps to identify the place where you'll find the device info at sysfs; 2) This is a V4L2 API non-compliance. All drivers should be compliant with the API; 3) If we all agree that bus_info doesn't matter at all and decide to change V4L2 API, we'll still have a big trouble: most devices don't have a serial number. The other patches are ok. Cheers, Mauro --- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/linux/drivers/media/video/pvrusb2/pvrusb2-v4l2.c Wed Jan 14 01:24:20 2009 -0600 +++ b/linux/drivers/media/video/pvrusb2/pvrusb2-v4l2.c Wed Jan 14 01:30:53 2009 -0600 @@ -205,7 +205,7 @@ static long pvr2_v4l2_do_ioctl(struct fi struct v4l2_capability *cap = arg; memcpy(cap, &pvr_capability, sizeof(struct v4l2_capability)); - strlcpy(cap->bus_info,pvr2_hdw_get_bus_info(hdw), + strlcpy(cap->bus_info, pvr2_hdw_get_device_identifier(hdw), sizeof(cap->bus_info)); strlcpy(cap->card,pvr2_hdw_get_desc(hdw),sizeof(cap->card));