From patchwork Tue Feb 10 19:59:05 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Nicola Soranzo X-Patchwork-Id: 6511 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n1AJx96W003142 for ; Tue, 10 Feb 2009 19:59:09 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752351AbZBJT7H (ORCPT ); Tue, 10 Feb 2009 14:59:07 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754619AbZBJT7H (ORCPT ); Tue, 10 Feb 2009 14:59:07 -0500 Received: from smtp.sissa.it ([147.122.11.135]:49186 "EHLO smtp.sissa.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753084AbZBJT7G convert rfc822-to-8bit (ORCPT ); Tue, 10 Feb 2009 14:59:06 -0500 Received: from ozzy.localnet (dhpc-2-26.sissa.it [147.122.2.206]) by smtp.sissa.it (Postfix) with ESMTP id 197F31B4804C; Tue, 10 Feb 2009 20:59:02 +0100 (CET) From: Nicola Soranzo To: Mauro Carvalho Chehab Subject: Re: [PATCH] em28xx: Codign style fixes and a typo correction Date: Tue, 10 Feb 2009 20:59:05 +0100 User-Agent: KMail/1.10.4 (Linux/2.6.27.12-170.2.5.fc10.i686; KDE/4.1.4; i686; ; ) References: <200902091750.45091.nsoranzo@tiscali.it> <20090209194910.22015d34@pedra.chehab.org> In-Reply-To: <20090209194910.22015d34@pedra.chehab.org> Cc: linux-media@vger.kernel.org MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200902102059.05536.nsoranzo@tiscali.it> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Alle lunedì 09 febbraio 2009, hai scritto: > On Mon, 9 Feb 2009 17:50:44 +0100 > Nicola Soranzo wrote: > > Lots of codign style fixes and a typo correction for em28xx. > > > > Priority: low > > > > Signed-off-by: Nicola Soranzo > > > > --- > > diff -r 71e5a36634ea linux/drivers/media/video/em28xx/em28xx-audio.c > > --- a/linux/drivers/media/video/em28xx/em28xx-audio.c Mon Feb 02 10:33:31 > > 2009 +0100 > > +++ b/linux/drivers/media/video/em28xx/em28xx-audio.c Mon Feb 09 12:47:13 > > 2009 +0100 > > @@ -264,8 +264,7 @@ > > } > > > > #if LINUX_VERSION_CODE <= KERNEL_VERSION(2, 6, 16) > > -static int snd_pcm_alloc_vmalloc_buffer(snd_pcm_substream_t *subs, > > - size_t size) > > +static int snd_pcm_alloc_vmalloc_buffer(snd_pcm_substream_t *subs, > > size_t size) > > Please, prefer, instead, something like: > +static int snd_pcm_alloc_vmalloc_buffer(snd_pcm_substream_t *subs, > size_t size) This part was line wrapped by KMail (I've changed its setting as suggested), the original was: The function definition is <= 80 characters, so I've put it on one line. Do you anyway prefer the second parameter on the other line for consistency? Thanks for the review, I've fixed all other required changes and I will send the new version later. Nicola --- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff -r 9cb19f080660 linux/drivers/media/video/em28xx/em28xx-audio.c --- a/linux/drivers/media/video/em28xx/em28xx-audio.c Tue Feb 10 05:26:05 2009 -0200 +++ b/linux/drivers/media/video/em28xx/em28xx-audio.c Tue Feb 10 20:33:23 2009 +0100 @@ -264,8 +264,7 @@ static int em28xx_cmd(struct em28xx *dev } #if LINUX_VERSION_CODE <= KERNEL_VERSION(2, 6, 16) -static int snd_pcm_alloc_vmalloc_buffer(snd_pcm_substream_t *subs, - size_t size) +static int snd_pcm_alloc_vmalloc_buffer(snd_pcm_substream_t *subs, size_t size) #else static int snd_pcm_alloc_vmalloc_buffer(struct snd_pcm_substream *subs, size_t size)