From patchwork Thu Feb 18 19:50:41 2010
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Tobias Lorenz <tobias.lorenz@gmx.net>
X-Patchwork-Id: 80422
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by demeter.kernel.org (8.14.3/8.14.3) with ESMTP id o1IJornr006620
	for <patchwork-media@patchwork.kernel.org>;
	Thu, 18 Feb 2010 19:50:53 GMT
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758031Ab0BRTuw (ORCPT
	<rfc822;patchwork-media@patchwork.kernel.org>);
	Thu, 18 Feb 2010 14:50:52 -0500
Received: from mail.gmx.net ([213.165.64.20]:46664 "HELO mail.gmx.net"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP
	id S1753335Ab0BRTuv (ORCPT <rfc822;linux-media@vger.kernel.org>);
	Thu, 18 Feb 2010 14:50:51 -0500
Received: (qmail invoked by alias); 18 Feb 2010 19:50:48 -0000
Received: from g226217044.adsl.alicedsl.de (EHLO tobias-laptop.localnet)
	[92.226.217.44]
	by mail.gmx.net (mp007) with SMTP; 18 Feb 2010 20:50:48 +0100
X-Authenticated: #2283611
X-Provags-ID: V01U2FsdGVkX1+zCeF/17qzgVCqtqisLv/edF5sKifktWI9Y5jeKm
	vbzcnbyluY1B/j
From: Tobias Lorenz <tobias.lorenz@gmx.net>
To: Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: Re: [PATCH] radio-si470x-common: -EINVAL overwritten in
	si470x_vidioc_s_tuner()
Date: Thu, 18 Feb 2010 20:50:41 +0100
User-Agent: KMail/1.12.4 (Linux/2.6.32-trunk-686; KDE/4.3.4; i686; ; )
Cc: Roel Kluin <roel.kluin@gmail.com>, linux-media@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>
References: <4B69D2F5.2050100@gmail.com>
	<201002032252.36514.tobias.lorenz@gmx.net>
	<4B6A242C.8060104@infradead.org>
In-Reply-To: <4B6A242C.8060104@infradead.org>
MIME-Version: 1.0
Message-Id: <201002182050.41968.tobias.lorenz@gmx.net>
X-Y-GMX-Trusted: 0
X-FuHaFi: 0.53000000000000003
Sender: linux-media-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-media.vger.kernel.org>
X-Mailing-List: linux-media@vger.kernel.org
X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by
	milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]);
	Thu, 18 Feb 2010 19:50:53 +0000 (UTC)


--- a/linux/drivers/media/radio/si470x/radio-si470x-common.c	Thu Feb 11 23:11:30 2010 -0200
+++ b/linux/drivers/media/radio/si470x/radio-si470x-common.c	Thu Feb 18 20:31:33 2010 +0100
@@ -748,7 +748,7 @@
 		struct v4l2_tuner *tuner)
 {
 	struct si470x_device *radio = video_drvdata(file);
-	int retval = -EINVAL;
+	int retval = 0;
 
 	/* safety checks */
 	retval = si470x_disconnect_check(radio);