From patchwork Sun Oct 31 22:18:42 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 293802 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id o9VMJKxr012365 for ; Sun, 31 Oct 2010 22:19:20 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753435Ab0JaWTD (ORCPT ); Sun, 31 Oct 2010 18:19:03 -0400 Received: from mail-yw0-f46.google.com ([209.85.213.46]:60856 "EHLO mail-yw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753157Ab0JaWTA (ORCPT ); Sun, 31 Oct 2010 18:19:00 -0400 Received: by ywc21 with SMTP id 21so470200ywc.19 for ; Sun, 31 Oct 2010 15:19:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:date :user-agent:cc:references:in-reply-to:mime-version:content-type :content-transfer-encoding:message-id; bh=FRY5rNuTy3yt1iSL7VA1J34TF5NbSJOxSm6MU7fVh6w=; b=x/HY+2yngS7rPofj6eLKd5JTDpNbtLscm6vr4AjUT4xZsI7Dp7x2A6sN2V9v4B4XeD ucsLBGxLtVur+BMrNLWIsZds9pjcqfddoJy6fEfIJ+ivySPo5b5dGDmuGp39BtKwZDGZ CCafxUsLvxmgzWX/5A8tJtTHJqOWIS5tXRrq8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding:message-id; b=GKkqCEMSUwdOb4+ViABWhsY5YbumgZpZJzYNxMFQuk8S4NpfRWJfXGqGsvMIipa7do TUczi1819hwMTn+uUBG/OA7Lc9LdP/3rAnNtJGZ+ctymv/MtCyT2S7xDwVoJ8Pn/vUcu F7L4unhSYN/ZrZnd05iOohFC7f5eAbzJhXGgA= Received: by 10.151.147.19 with SMTP id z19mr26805746ybn.150.1288563539911; Sun, 31 Oct 2010 15:18:59 -0700 (PDT) Received: from mailhub.coreip.homeip.net (c-24-6-153-206.hsd1.ca.comcast.net [24.6.153.206]) by mx.google.com with ESMTPS id t9sm6351094ybe.9.2010.10.31.15.18.55 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 31 Oct 2010 15:18:58 -0700 (PDT) From: Dmitry Torokhov To: Stefan Richter , Linus Torvalds Subject: Re: drivers/media/IR/ir-keytable.c::ir_getkeycode - 'retval' may be used uninitialized Date: Sun, 31 Oct 2010 15:18:42 -0700 User-Agent: KMail/1.13.5 (Linux/2.6.36+; KDE/4.4.5; x86_64; ; ) Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, mchehab@redhat.com References: In-Reply-To: MIME-Version: 1.0 Message-Id: <201010311518.42998.dmitry.torokhov@gmail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter1.kernel.org [140.211.167.41]); Sun, 31 Oct 2010 22:19:20 +0000 (UTC) diff --git a/drivers/media/IR/ir-keytable.c b/drivers/media/IR/ir-keytable.c index 9186b45..f7fafff 100644 --- a/drivers/media/IR/ir-keytable.c +++ b/drivers/media/IR/ir-keytable.c @@ -389,6 +389,8 @@ static int ir_getkeycode(struct input_dev *dev, ke->len = sizeof(entry->scancode); memcpy(ke->scancode, &entry->scancode, sizeof(entry->scancode)); + retval = 0; + out: spin_unlock_irqrestore(&rc_tab->lock, flags); return retval;