| Message ID | 20110615133206.GW8141@htj.dyndns.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
Index: work/drivers/media/dvb/dvb-usb/technisat-usb2.c =================================================================== --- work.orig/drivers/media/dvb/dvb-usb/technisat-usb2.c +++ work/drivers/media/dvb/dvb-usb/technisat-usb2.c @@ -765,10 +765,8 @@ static void technisat_usb2_disconnect(st /* work and stuff was only created when the device is is hot-state */ if (dev != NULL) { struct technisat_usb2_state *state = dev->priv; - if (state != NULL) { + if (state != NULL) cancel_delayed_work_sync(&state->green_led_work); - flush_scheduled_work(); - } } dvb_usb_device_exit(intf);
flush_scheduled_work() is deprecated and scheduled to be removed. technisat-usb2 already sync-cancels the only work item it uses and there's no reason for it to call flush_scheduled_work(). Don't use it. Signed-off-by: Tejun Heo <tj@kernel.org> Cc: Mauro Carvalho Chehab <mchehab@infradead.org> Cc: Patrick Boettcher <pboettcher@kernellabs.com> --- I was re-scanning source tree to prepare for deprecation of flush_scheduled_work() and found out new driver added usage unnecessarily. Can you please include this patch so that it gets propagated to linux-next soonish? Thank you. drivers/media/dvb/dvb-usb/technisat-usb2.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html