From patchwork Sat Jul 2 09:16:44 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans Verkuil X-Patchwork-Id: 940292 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p629GqK7018977 for ; Sat, 2 Jul 2011 09:16:52 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753456Ab1GBJQt (ORCPT ); Sat, 2 Jul 2011 05:16:49 -0400 Received: from smtp-vbr16.xs4all.nl ([194.109.24.36]:3204 "EHLO smtp-vbr16.xs4all.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752705Ab1GBJQt (ORCPT ); Sat, 2 Jul 2011 05:16:49 -0400 Received: from tschai.localnet (215.80-203-102.nextgentel.com [80.203.102.215]) (authenticated bits=0) by smtp-vbr16.xs4all.nl (8.13.8/8.13.8) with ESMTP id p629Gj7T057259 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 2 Jul 2011 11:16:46 +0200 (CEST) (envelope-from hverkuil@xs4all.nl) From: Hans Verkuil To: Jonathan Corbet Subject: Missing 'select VIDEOBUF2_DMA_CONTIG' Date: Sat, 2 Jul 2011 11:16:44 +0200 User-Agent: KMail/1.13.5 (Linux/3.0.0-rc1-tschai; KDE/4.6.2; x86_64; ; ) Cc: "linux-media" MIME-Version: 1.0 Message-Id: <201107021116.44556.hverkuil@xs4all.nl> X-Virus-Scanned: by XS4ALL Virus Scanner Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Sat, 02 Jul 2011 09:16:52 +0000 (UTC) Hi Jon, I get this error when compiling the latest for_v3.1 media_tree: Kernel: arch/x86/boot/bzImage is ready (#400) ERROR: "vb2_dma_contig_init_ctx" [drivers/media/video/marvell-ccic/cafe_ccic.ko] undefined! ERROR: "vb2_dma_contig_cleanup_ctx" [drivers/media/video/marvell-ccic/cafe_ccic.ko] undefined! ERROR: "vb2_dma_contig_memops" [drivers/media/video/marvell-ccic/cafe_ccic.ko] undefined! make[1]: *** [__modpost] Error 1 make: *** [modules] Error 2 I think this is missing: Can you confirm this? Regards, Hans --- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/media/video/marvell-ccic/Kconfig b/drivers/media/video/marvell-ccic/Kconfig index 22314a0..68ff5d6 100644 --- a/drivers/media/video/marvell-ccic/Kconfig +++ b/drivers/media/video/marvell-ccic/Kconfig @@ -3,6 +3,7 @@ config VIDEO_CAFE_CCIC depends on PCI && I2C && VIDEO_V4L2 select VIDEO_OV7670 select VIDEOBUF2_VMALLOC + select VIDEOBUF2_DMA_CONTIG ---help--- This is a video4linux2 driver for the Marvell 88ALP01 integrated CMOS camera controller. This is the controller found on first-