From patchwork Fri Jul 8 09:00:37 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean Delvare X-Patchwork-Id: 956462 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p6890hO5016124 for ; Fri, 8 Jul 2011 09:00:43 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754234Ab1GHJAk (ORCPT ); Fri, 8 Jul 2011 05:00:40 -0400 Received: from cantor2.suse.de ([195.135.220.15]:53601 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751352Ab1GHJAj (ORCPT ); Fri, 8 Jul 2011 05:00:39 -0400 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.221.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id CF6488A95F; Fri, 8 Jul 2011 11:00:38 +0200 (CEST) From: Jean Delvare Organization: Suse Linux To: linux-media@vger.kernel.org Subject: [PATCH] [media] tea5764: Fix module parameter permissions Date: Fri, 8 Jul 2011 11:00:37 +0200 User-Agent: KMail/1.12.4 (Linux/2.6.32.36-0.5-pae; KDE/4.3.5; i686; ; ) Cc: Mauro Carvalho Chehab , Fabio Belavenuto MIME-Version: 1.0 Message-Id: <201107081100.37406.jdelvare@suse.de> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Fri, 08 Jul 2011 09:00:43 +0000 (UTC) The third parameter of module_param is supposed to represent sysfs file permissions. A value of "1" leads to the following: $ ls -l /sys/module/radio_tea5764/parameters/ total 0 ---------x 1 root root 4096 Jul 8 09:17 use_xtal I am changing it to "0" to align with the other module parameters in this driver. Signed-off-by: Jean Delvare Cc: Mauro Carvalho Chehab Cc: Fabio Belavenuto --- drivers/media/radio/radio-tea5764.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-3.0-rc6.orig/drivers/media/radio/radio-tea5764.c 2011-05-20 10:41:19.000000000 +0200 +++ linux-3.0-rc6/drivers/media/radio/radio-tea5764.c 2011-07-08 09:15:16.000000000 +0200 @@ -596,7 +596,7 @@ MODULE_AUTHOR(DRIVER_AUTHOR); MODULE_DESCRIPTION(DRIVER_DESC); MODULE_LICENSE("GPL"); -module_param(use_xtal, int, 1); +module_param(use_xtal, int, 0); MODULE_PARM_DESC(use_xtal, "Chip have a xtal connected in board"); module_param(radio_nr, int, 0); MODULE_PARM_DESC(radio_nr, "video4linux device number to use");