| Message ID | 20110723185303.GA3711@shale.localdomain (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
Hi, Thanks I've added your patch to my gspca/pwc tree and send an updated pull request to Mauro including your patch. Regards, Hans On 07/23/2011 08:53 PM, Dan Carpenter wrote: > '!' has higher precedence than'&' so we need parenthesis here. > > Signed-off-by: Dan Carpenter<error27@gmail.com> > > diff --git a/drivers/media/video/pwc/pwc-v4l.c b/drivers/media/video/pwc/pwc-v4l.c > index e9a0e94..8c70e64 100644 > --- a/drivers/media/video/pwc/pwc-v4l.c > +++ b/drivers/media/video/pwc/pwc-v4l.c > @@ -338,7 +338,7 @@ int pwc_init_controls(struct pwc_device *pdev) > if (pdev->restore_factory) > pdev->restore_factory->flags = V4L2_CTRL_FLAG_UPDATE; > > - if (!pdev->features& FEATURE_MOTOR_PANTILT) > + if (!(pdev->features& FEATURE_MOTOR_PANTILT)) > return hdl->error; > > /* Motor pan / tilt / reset */ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/video/pwc/pwc-v4l.c b/drivers/media/video/pwc/pwc-v4l.c index e9a0e94..8c70e64 100644 --- a/drivers/media/video/pwc/pwc-v4l.c +++ b/drivers/media/video/pwc/pwc-v4l.c @@ -338,7 +338,7 @@ int pwc_init_controls(struct pwc_device *pdev) if (pdev->restore_factory) pdev->restore_factory->flags = V4L2_CTRL_FLAG_UPDATE; - if (!pdev->features & FEATURE_MOTOR_PANTILT) + if (!(pdev->features & FEATURE_MOTOR_PANTILT)) return hdl->error; /* Motor pan / tilt / reset */
'!' has higher precedence than '&' so we need parenthesis here. Signed-off-by: Dan Carpenter <error27@gmail.com> -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html