From patchwork Sat Jul 23 18:53:03 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 1002522 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p6NIt9c5026401 for ; Sat, 23 Jul 2011 18:55:09 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753312Ab1GWSzF (ORCPT ); Sat, 23 Jul 2011 14:55:05 -0400 Received: from mail-wy0-f174.google.com ([74.125.82.174]:53643 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753265Ab1GWSzD (ORCPT ); Sat, 23 Jul 2011 14:55:03 -0400 Received: by wyg8 with SMTP id 8so2070406wyg.19 for ; Sat, 23 Jul 2011 11:55:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; bh=nuguhhM0BQyHUrZ5SsVyQVFkq9CqkR61ix1Qz5xZqZk=; b=YSr14S0NKliQlzgH+pzW0ratjKLFpXsAy/pTmFXtRv12o1z3gcgA2idHBco7uZ0zsW 2Ecs0egGD5Jaz21u4OGSjAUlx8ku9LIuvxy3YnekP74SO4xjwvZQUXKDES///Tsjf5sI UcDQ0H7+S595Md2Hbn5aa6aOxcYjlHeJmJZK0= Received: by 10.216.81.2 with SMTP id l2mr1474604wee.22.1311447301629; Sat, 23 Jul 2011 11:55:01 -0700 (PDT) Received: from shale.localdomain ([41.202.225.150]) by mx.google.com with ESMTPS id n6sm1681318wed.40.2011.07.23.11.54.57 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 23 Jul 2011 11:55:00 -0700 (PDT) Date: Sat, 23 Jul 2011 21:53:03 +0300 From: Dan Carpenter To: Mauro Carvalho Chehab Cc: Hans de Goede , Hans Verkuil , =?iso-8859-1?Q?Jean-Fran=E7ois?= Moine , "open list:MEDIA INPUT INFRA..." , kernel-janitors@vger.kernel.org Subject: [patch] [media] pwc: precedence bug in pwc_init_controls() Message-ID: <20110723185303.GA3711@shale.localdomain> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Sat, 23 Jul 2011 18:55:09 +0000 (UTC) '!' has higher precedence than '&' so we need parenthesis here. Signed-off-by: Dan Carpenter --- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/media/video/pwc/pwc-v4l.c b/drivers/media/video/pwc/pwc-v4l.c index e9a0e94..8c70e64 100644 --- a/drivers/media/video/pwc/pwc-v4l.c +++ b/drivers/media/video/pwc/pwc-v4l.c @@ -338,7 +338,7 @@ int pwc_init_controls(struct pwc_device *pdev) if (pdev->restore_factory) pdev->restore_factory->flags = V4L2_CTRL_FLAG_UPDATE; - if (!pdev->features & FEATURE_MOTOR_PANTILT) + if (!(pdev->features & FEATURE_MOTOR_PANTILT)) return hdl->error; /* Motor pan / tilt / reset */