From patchwork Tue Feb 19 21:03:53 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Bombe X-Patchwork-Id: 2165151 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 24C303FCF6 for ; Tue, 19 Feb 2013 21:03:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933691Ab3BSVD4 (ORCPT ); Tue, 19 Feb 2013 16:03:56 -0500 Received: from infernal.debian.net ([176.28.9.132]:51473 "EHLO infernal.debian.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933239Ab3BSVD4 (ORCPT ); Tue, 19 Feb 2013 16:03:56 -0500 Received: from ppp-188-174-185-111.dynamic.mnet-online.de ([188.174.185.111] helo=amos.fritz.box) by infernal.debian.net with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1U7uLy-0007P5-Bx; Tue, 19 Feb 2013 22:03:54 +0100 Received: from andreas by amos.fritz.box with local (Exim 4.80) (envelope-from ) id 1U7uLx-0001p7-Qu; Tue, 19 Feb 2013 22:03:53 +0100 Date: Tue, 19 Feb 2013 22:03:53 +0100 From: Andreas Bombe To: linux-media@vger.kernel.org Cc: Laurent Pinchart Subject: [media-ctl PATCH] Fix linking of shared libraries Message-ID: <20130219210353.GA6935@amos.fritz.box> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org When using libudev, it is actually libmediactl that uses it and not the media-ctl executable. libv4l2subdev uses functions from libmediactl and therefore needs to be linked against it. Signed-off-by: Andreas Bombe Acked-by: Laurent Pinchart --- In light of their relative simplicity as well as cross dependency, does it make sense to keep libmediactl and libv4l2subdev as separate libraries? src/Makefile.am | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 2583464..f754763 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -1,12 +1,12 @@ lib_LTLIBRARIES = libmediactl.la libv4l2subdev.la libmediactl_la_SOURCES = mediactl.c +libmediactl_la_CFLAGS = $(LIBUDEV_CFLAGS) +libmediactl_la_LDFLAGS = $(LIBUDEV_LIBS) libv4l2subdev_la_SOURCES = v4l2subdev.c +libv4l2subdev_la_LIBADD = libmediactl.la mediactl_includedir=$(includedir)/mediactl mediactl_include_HEADERS = mediactl.h v4l2subdev.h bin_PROGRAMS = media-ctl -media_ctl_CFLAGS = $(LIBUDEV_CFLAGS) -media_ctl_LDFLAGS = $(LIBUDEV_LIBS) media_ctl_SOURCES = main.c options.c options.h tools.h media_ctl_LDADD = libmediactl.la libv4l2subdev.la -