| Message ID | 20130416182654.27773.74830.stgit@warthog.procyon.org.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Em 16-04-2013 15:26, David Howells escreveu: > Don't print proc_dir_entry data in debug as we're soon to have no direct > access to the contents of the PDE. Print what was put in there instead. Let me just apply this simple one, as it doesn't depend on the rest of the patches in this series. > > Signed-off-by: David Howells <dhowells@redhat.com> > cc: mjpeg-users@lists.sourceforge.net > cc: linux-media@vger.kernel.org > --- > > drivers/media/pci/zoran/zoran_procfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/pci/zoran/zoran_procfs.c b/drivers/media/pci/zoran/zoran_procfs.c > index 07a104d..f7ceee0 100644 > --- a/drivers/media/pci/zoran/zoran_procfs.c > +++ b/drivers/media/pci/zoran/zoran_procfs.c > @@ -201,7 +201,7 @@ zoran_proc_init (struct zoran *zr) > dprintk(2, > KERN_INFO > "%s: procfs entry /proc/%s allocated. data=%p\n", > - ZR_DEVNAME(zr), name, zr->zoran_proc->data); > + ZR_DEVNAME(zr), name, zr); It is just a debug message, so changing it looks fine. > } else { > dprintk(1, KERN_ERR "%s: Unable to initialise /proc/%s\n", > ZR_DEVNAME(zr), name); > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/pci/zoran/zoran_procfs.c b/drivers/media/pci/zoran/zoran_procfs.c index 07a104d..f7ceee0 100644 --- a/drivers/media/pci/zoran/zoran_procfs.c +++ b/drivers/media/pci/zoran/zoran_procfs.c @@ -201,7 +201,7 @@ zoran_proc_init (struct zoran *zr) dprintk(2, KERN_INFO "%s: procfs entry /proc/%s allocated. data=%p\n", - ZR_DEVNAME(zr), name, zr->zoran_proc->data); + ZR_DEVNAME(zr), name, zr); } else { dprintk(1, KERN_ERR "%s: Unable to initialise /proc/%s\n", ZR_DEVNAME(zr), name);
Don't print proc_dir_entry data in debug as we're soon to have no direct access to the contents of the PDE. Print what was put in there instead. Signed-off-by: David Howells <dhowells@redhat.com> cc: mjpeg-users@lists.sourceforge.net cc: linux-media@vger.kernel.org --- drivers/media/pci/zoran/zoran_procfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html