| Message ID | 201311112331.37052.linux@rainbow-software.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Ondrej, On 11/11/2013 11:31 PM, Ondrej Zary wrote: > Add a small delay at the end of configure_clock() to allow sensor to initialize. > This is needed by Asus VX2S laptop webcam to detect sensor type properly (the already-supported MT9M112). > > Signed-off-by: Ondrej Zary<linux@rainbow-software.org> > --- > drivers/media/usb/gspca/stk1135.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/media/usb/gspca/stk1135.c b/drivers/media/usb/gspca/stk1135.c > index 8add2f7..d8a813c 100644 > --- a/drivers/media/usb/gspca/stk1135.c > +++ b/drivers/media/usb/gspca/stk1135.c > @@ -361,6 +361,9 @@ static void stk1135_configure_clock(struct gspca_dev *gspca_dev) > > /* set serial interface clock divider (30MHz/0x1f*16+2) = 60240 kHz) */ > reg_w(gspca_dev, STK1135_REG_SICTL + 2, 0x1f); > + > + /* wait a while for sensor to catch up */ > + udelay(1000); Instead of this 1 ms busy loop waiting it might be more optimal to use usleep_range(), e.g. usleep_range(1000, 1100); > } > > static void stk1135_camera_disable(struct gspca_dev *gspca_dev) -- Regards, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/usb/gspca/stk1135.c b/drivers/media/usb/gspca/stk1135.c index 8add2f7..d8a813c 100644 --- a/drivers/media/usb/gspca/stk1135.c +++ b/drivers/media/usb/gspca/stk1135.c @@ -361,6 +361,9 @@ static void stk1135_configure_clock(struct gspca_dev *gspca_dev) /* set serial interface clock divider (30MHz/0x1f*16+2) = 60240 kHz) */ reg_w(gspca_dev, STK1135_REG_SICTL + 2, 0x1f); + + /* wait a while for sensor to catch up */ + udelay(1000); } static void stk1135_camera_disable(struct gspca_dev *gspca_dev)
Add a small delay at the end of configure_clock() to allow sensor to initialize. This is needed by Asus VX2S laptop webcam to detect sensor type properly (the already-supported MT9M112). Signed-off-by: Ondrej Zary <linux@rainbow-software.org> --- drivers/media/usb/gspca/stk1135.c | 3 +++ 1 file changed, 3 insertions(+)