diff mbox

stk1160 / ehci-pci 0000:00:0a.0: DMA-API: device driver maps memory fromstack [addr=ffff88003d0b56bf]

Message ID 20140414121231.GA6393@arch.cereza (mailing list archive)
State New, archived
Headers show

Commit Message

Ezequiel Garcia April 14, 2014, 12:12 p.m. UTC 
On Apr 13, Sander Eikelenboom wrote:
> 
> I'm hitting this warning on boot with a syntek usb video grabber, it's not clear 
> to me if it's a driver issue of the stk1160 or a generic ehci issue.
> 

Can't reproduce the same warning easily here. Could you test the following patch?

Comments

Ezequiel Garcia April 14, 2014, 4:06 p.m. UTC | #1 
On Apr 14, Ezequiel Garcia wrote:
> On Apr 13, Sander Eikelenboom wrote:
> > 
> > I'm hitting this warning on boot with a syntek usb video grabber, it's not clear 
> > to me if it's a driver issue of the stk1160 or a generic ehci issue.
> > 
> 
> Can't reproduce the same warning easily here. Could you test the following patch?
> 

Nevermind, just reproduced the warning. I'll be pushing a fix now.
diff mbox

Patch

diff --git a/drivers/media/usb/stk1160/stk1160-core.c b/drivers/media/usb/stk1160/stk1160-core.c
index 34a26e0..304fdb3 100644
--- a/drivers/media/usb/stk1160/stk1160-core.c
+++ b/drivers/media/usb/stk1160/stk1160-core.c
@@ -71,13 +71,14 @@  int stk1160_read_reg(struct stk1160 *dev, u16 reg, u8 *value)
 	*value = 0;
 	ret = usb_control_msg(dev->udev, pipe, 0x00,
 			USB_DIR_IN | USB_TYPE_VENDOR | USB_RECIP_DEVICE,
-			0x00, reg, value, sizeof(u8), HZ);
+			0x00, reg, dev->urb_buf, sizeof(u8), HZ);
 	if (ret < 0) {
 		stk1160_err("read failed on reg 0x%x (%d)\n",
 			reg, ret);
 		return ret;
 	}
 
+	*value = dev->urb_buf[0];
 	return 0;
 }