From patchwork Mon Jun 30 14:56:33 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mauro Carvalho Chehab X-Patchwork-Id: 4450501 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 71781BEEAA for ; Mon, 30 Jun 2014 14:56:45 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5B5DA202F8 for ; Mon, 30 Jun 2014 14:56:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 98180201EF for ; Mon, 30 Jun 2014 14:56:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751379AbaF3O4k (ORCPT ); Mon, 30 Jun 2014 10:56:40 -0400 Received: from mailout3.w2.samsung.com ([211.189.100.13]:52252 "EHLO usmailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751223AbaF3O4j (ORCPT ); Mon, 30 Jun 2014 10:56:39 -0400 Received: from uscpsbgm1.samsung.com (u114.gpu85.samsung.co.kr [203.254.195.114]) by usmailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N7Z00BQCLID3N80@usmailout3.samsung.com> for linux-media@vger.kernel.org; Mon, 30 Jun 2014 10:56:37 -0400 (EDT) X-AuditID: cbfec372-b7fe76d00000687e-91-53b17aa55364 Received: from ussync4.samsung.com ( [203.254.195.84]) by uscpsbgm1.samsung.com (USCPMTA) with SMTP id 61.4E.26750.5AA71B35; Mon, 30 Jun 2014 10:56:37 -0400 (EDT) Received: from recife.lan ([105.144.34.13]) by ussync4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0N7Z00CSOLIA7V70@ussync4.samsung.com>; Mon, 30 Jun 2014 10:56:37 -0400 (EDT) Date: Mon, 30 Jun 2014 11:56:33 -0300 From: Mauro Carvalho Chehab To: Vincent McIntyre Cc: linux-media Subject: Re: regression: (repost) firmware loading for dvico dual digital 4 Message-id: <20140630115633.6c5b5d95.m.chehab@samsung.com> In-reply-to: References: X-Mailer: Claws Mail 3.10.0 (GTK+ 2.24.22; x86_64-redhat-linux-gnu) MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprILMWRmVeSWpSXmKPExsVy+t/hEN2lVRuDDRYtMLbo2bCV1eLzNjYH Jo+ds+6ye3zeJBfAFMVlk5Kak1mWWqRvl8CVsaMpt2CHZMX1X0dZGhjXinQxcnJICJhInJ7z mh3CFpO4cG89WxcjF4eQwBJGieZLk9khnEYmicPbbzCBVLEIqEqsaXgI1sEmYCTxqrGFtYuR g0NEwFDi3nFvEJNZQFfi+Y0skAphAW+J01+XgVXzClhJrP15hQWkhFMgWGL6y2yQsJBAgMTv 7pmMECc4S1xoXs4CUS4o8WPyPTCbWUBLYvO2JlYIW15i85q3zBMYBWYhKZuFpGwWkrIFjMyr GEVLi5MLipPScw31ihNzi0vz0vWS83M3MUKCsWgH47MNVocYBTgYlXh4NZZtCBZiTSwrrsw9 xCjBwawkwnvTZ2OwEG9KYmVValF+fFFpTmrxIUYmDk6pBsYZAbd2n/K4O+2USFrhpfVlC2bf t57wcsm9JoEbEzNvOc3ureF3u/fe50r0jnK5J+1TrBamb3ys/Eb3b6vaw0XxFdHMYnNkRfvr LOp/X8mz5Nwh8GSRaLNwEWdIgAdfxgK32wf4FLdcefBOdvm2Y63cL42e/FI6J7lpnZPjvp49 TVorVBlWzPypxFKckWioxVxUnAgAckhB4CQCAAA= Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Em Mon, 30 Jun 2014 23:19:46 +1000 Vincent McIntyre escreveu: > Hi, > > I am reposting this since it got ignored/missed last time around... > > On 5/14/14, Vincent McIntyre wrote: > > Hi, > > > > Antti asked me to report this. > > > > I built the latest media_build git on Ubuntu 12.04, with 3.8.0 kernel, > > using './build --main-git'. > > The attached tarball has the relvant info. > > > > Without the media_build modules, firmware loads fine (file dmesg.1) > > Once I build and install the media_build modules, the firmware no > > longer loads. (dmesg.2) > > > > The firmware loading issue appears to have been reported to ubuntu (a > > later kernel, 3.11) with a possible fix proposed, see > > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1291459 > > > > I can post lspci etc details if people want. > > > > An updated version of the tar file is attached. > > dmesg.1 is from 3.8.0-38 plus media-build modules and shows the > firmware loading issue. > The media-build HEAD revision was > commit e4a8d40f63afa8b0276ea7758d9b4d32e64a964d > Author: Hans Verkuil > Date: Wed Jun 18 10:27:51 2014 +0200 > > dmesg.2 is from 3.8.0-42 with the ubuntu-provided modules and does not > show the issue. > > The issue occurs in later ubuntu kernels, 3.11 as noted previously > and 3.13.0-30. > > The OS is ubuntu 12.04 LTS, amd64. > > I looked into bisecting this but could not figure out a procedure > since the 'build' script tries really hard to use the latest > media-build and kernel sources. It looks like one has to run the > media-build 'make' against a checkout of the vanilla kernel that > roughly corresponds in time (or at least is not from a time later than > the current media-build revision that is checked out). > > > Please respond this time Next time, please add the logs directly at the email, as this makes clearer about what's the problem and what driver has the issues. Anyway, based on this: [ 16.332247] xc2028 0-0061: Loading firmware for type=BASE F8MHZ (3), id 0000000000000000. [ 16.344378] cxusb: i2c wr: len=64 is too big! I suspect that the enclosed patch should fix your issue. Please test. If it works, please reply to this email with: Tested-by: your name Cheers, Mauro - cxusb: increase buffer lenght to 80 bytes As reported by Vincent: [ 16.332247] xc2028 0-0061: Loading firmware for type=BASE F8MHZ (3), id 0000000000000000. [ 16.344378] cxusb: i2c wr: len=64 is too big! 64 bytes is too short for firmware load on this device. So, increase it to 80 bytes. Reported-by: Vincent McIntyre Signed-off-by: Mauro Carvalho Chehab Tested-by: Vincent McIntyre --- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/media/usb/dvb-usb/cxusb.c b/drivers/media/usb/dvb-usb/cxusb.c index 6acde5ee4324..a22726ccca64 100644 --- a/drivers/media/usb/dvb-usb/cxusb.c +++ b/drivers/media/usb/dvb-usb/cxusb.c @@ -44,7 +44,7 @@ #include "atbm8830.h" /* Max transfer size done by I2C transfer functions */ -#define MAX_XFER_SIZE 64 +#define MAX_XFER_SIZE 80 /* debug */ static int dvb_usb_cxusb_debug;