From patchwork Mon Nov 16 22:52:49 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benoit Parrot X-Patchwork-Id: 7631361 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 8F4C6BF90C for ; Mon, 16 Nov 2015 22:53:15 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 62DF3205DE for ; Mon, 16 Nov 2015 22:53:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3FFB5205D4 for ; Mon, 16 Nov 2015 22:53:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751914AbbKPWwy (ORCPT ); Mon, 16 Nov 2015 17:52:54 -0500 Received: from bear.ext.ti.com ([192.94.94.41]:48341 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751438AbbKPWwx (ORCPT ); Mon, 16 Nov 2015 17:52:53 -0500 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by bear.ext.ti.com (8.13.7/8.13.7) with ESMTP id tAGMqohG013964; Mon, 16 Nov 2015 16:52:50 -0600 Received: from DFLE73.ent.ti.com (dfle73.ent.ti.com [128.247.5.110]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id tAGMqojT006324; Mon, 16 Nov 2015 16:52:50 -0600 Received: from dflp32.itg.ti.com (10.64.6.15) by DFLE73.ent.ti.com (128.247.5.110) with Microsoft SMTP Server id 14.3.224.2; Mon, 16 Nov 2015 16:52:50 -0600 Received: from ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id tAGMqn4N018988; Mon, 16 Nov 2015 16:52:49 -0600 Date: Mon, 16 Nov 2015 16:52:49 -0600 From: Benoit Parrot To: Rob Herring CC: Hans Verkuil , , , Subject: Re: [Patch v4 2/2] media: v4l: ti-vpe: Document CAL driver Message-ID: <20151116225249.GQ3999@ti.com> References: <1447631628-9459-1-git-send-email-bparrot@ti.com> <1447631628-9459-3-git-send-email-bparrot@ti.com> <20151116152615.GA9256@rob-hp-laptop> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20151116152615.GA9256@rob-hp-laptop> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Rob Herring wrote on Mon [2015-Nov-16 09:26:16 -0600]: > On Sun, Nov 15, 2015 at 05:53:48PM -0600, Benoit Parrot wrote: > > Device Tree bindings for the Camera Adaptation Layer (CAL) driver > > Bindings are for h/w blocks, not drivers... OK I'll fix that. > > > > > Signed-off-by: Benoit Parrot > > --- > > Documentation/devicetree/bindings/media/ti-cal.txt | 70 ++++++++++++++++++++++ > > 1 file changed, 70 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/ti-cal.txt > > > > diff --git a/Documentation/devicetree/bindings/media/ti-cal.txt b/Documentation/devicetree/bindings/media/ti-cal.txt > > new file mode 100644 > > index 000000000000..680efadb6208 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/ti-cal.txt > > @@ -0,0 +1,70 @@ > > +Texas Instruments DRA72x CAMERA ADAPTATION LAYER (CAL) > > +------------------------------------------------------ > > + > > +The Camera Adaptation Layer (CAL) is a key component for image capture > > +applications. The capture module provides the system interface and the > > +processing capability to connect CSI2 image-sensor modules to the > > +DRA72x device. > > + > > +Required properties: > > +- compatible: must be "ti,cal" > > Needs to be more specific. See potential patch below. > > > +- reg: physical base address and length of the registers set for the 4 > > + memory regions required; > > Please list what the 4 regions are. See potential patch below. > > > +- reg-names: name associated with the memory regions described is ; > > Please list the names. See potential patch below. > > > +- interrupts: should contain IRQ line for the CAL; > > + > > +CAL supports 2 camera port nodes on MIPI bus. Each CSI2 camera port nodes > > +should contain a 'port' child node with child 'endpoint' node. Please > > +refer to the bindings defined in > > +Documentation/devicetree/bindings/media/video-interfaces.txt. > > + > > +Example: > > + cal: cal@4845b000 { > > + compatible = "ti,cal"; > > + ti,hwmods = "cal"; > > + reg = <0x4845B000 0x400>, > > + <0x4845B800 0x40>, > > + <0x4845B900 0x40>, > > + <0x4A002e94 0x4>; > > + reg-names = "cal_top", > > + "cal_rx_core0", > > + "cal_rx_core1", > > + "camerrx_control"; > > + interrupts = ; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + csi2_0: port@0 { > > Multiple ports should be under a ports node. The video-interfaces.txt bindings doc state: "All 'port' nodes can be grouped under optional 'ports' node" Doesn't that mean that 'ports' is then optional has show in the csi2 example provide in the same documents? > > > + #address-cells = <1>; > > + #size-cells = <0>; > > + reg = <0>; > > + endpoint { > > + slave-mode; > > + remote-endpoint = <&ar0330_1>; > > + }; > > + }; > > + csi2_1: port@1 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + reg = <1>; > > + }; > > + }; > > + > > + i2c5: i2c@4807c000 { > > + ar0330@10 { > > + compatible = "ti,ar0330"; > > + reg = <0x10>; > > + > > + port { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + ar0330_1: endpoint { > > + reg = <0>; > > + clock-lanes = <1>; > > + data-lanes = <0 2 3 4>; > > + remote-endpoint = <&csi2_0>; > > + }; > > + }; > > + }; > > + }; > > -- > > 1.8.5.1 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe devicetree" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html Potential fix for the above comments: Regards, Benoit --- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/Documentation/devicetree/bindings/media/ti-cal.txt b/Documentation/devicetree/bindings/media/ti-cal.txt index 680efadb6208..ef6f88de38c0 100644 --- a/Documentation/devicetree/bindings/media/ti-cal.txt +++ b/Documentation/devicetree/bindings/media/ti-cal.txt @@ -7,10 +7,11 @@ processing capability to connect CSI2 image-sensor modules to the DRA72x device. Required properties: -- compatible: must be "ti,cal" -- reg: physical base address and length of the registers set for the 4 - memory regions required; -- reg-names: name associated with the memory regions described is ; +- compatible: must be "ti,dra72-cal" +- reg: CAL Top level, Receiver Core #0, Receiver Core #1 and Camera RX + control address space +- reg-names: cal_top, cal_rx_core0, cal_rx_core1, and camerrx_control + registers - interrupts: should contain IRQ line for the CAL; CAL supports 2 camera port nodes on MIPI bus. Each CSI2 camera port nodes @@ -20,7 +21,7 @@ Documentation/devicetree/bindings/media/video-interfaces.txt. Example: cal: cal@4845b000 { - compatible = "ti,cal"; + compatible = "ti,dra72-cal"; ti,hwmods = "cal"; reg = <0x4845B000 0x400>, <0x4845B800 0x40>,