| Message ID | 20160719081040.2685845-2-arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 07/19/16 10:10, Arnd Bergmann wrote: > We cannot build the cec driver when the RC core is a module > and cec is built-in: > > drivers/staging/built-in.o: In function `cec_allocate_adapter': > :(.text+0x134): undefined reference to `rc_allocate_device' > drivers/staging/built-in.o: In function `cec_register_adapter': > :(.text+0x304): undefined reference to `rc_register_device' > > This adds an explicit dependency to avoid this case. We still > allow building when CONFIG_RC_CORE is disabled completely, > as the driver has checks for this case itself. This makes no sense: the rc_allocate_device and rc_register_device are under: #if IS_REACHABLE(CONFIG_RC_CORE) So it shouldn't be enabled at all, should it? Regards, Hans > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > I originally submitted this on June 29, but it may have gotten > lost as out of the three patch series, one patch got replaced > and another patch got applied, but nothing happened on this one. > --- > drivers/staging/media/cec/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/media/cec/Kconfig b/drivers/staging/media/cec/Kconfig > index 21457a1f6c9f..c623bd32a5b8 100644 > --- a/drivers/staging/media/cec/Kconfig > +++ b/drivers/staging/media/cec/Kconfig > @@ -1,6 +1,7 @@ > config MEDIA_CEC > bool "CEC API (EXPERIMENTAL)" > depends on MEDIA_SUPPORT > + depends on RC_CORE || !RC_CORE > select MEDIA_CEC_EDID > ---help--- > Enable the CEC API. > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tuesday, July 19, 2016 10:30:22 AM CEST Hans Verkuil wrote: > On 07/19/16 10:10, Arnd Bergmann wrote: > > We cannot build the cec driver when the RC core is a module > > and cec is built-in: > > > > drivers/staging/built-in.o: In function `cec_allocate_adapter': > > :(.text+0x134): undefined reference to `rc_allocate_device' > > drivers/staging/built-in.o: In function `cec_register_adapter': > > :(.text+0x304): undefined reference to `rc_register_device' > > > > This adds an explicit dependency to avoid this case. We still > > allow building when CONFIG_RC_CORE is disabled completely, > > as the driver has checks for this case itself. > > This makes no sense: the rc_allocate_device and rc_register_device > are under: > > #if IS_REACHABLE(CONFIG_RC_CORE) > > So it shouldn't be enabled at all, should it? My mistake, I forgot to remove my patch from the backlog after you added 5bb2399a4fe4 ("[media] cec: fix Kconfig dependency problems"), and I saw that it's still marked as "new" in patchwork with no reply. I'll drop the patch from my local series and won't submit it again, sorry for the mixup. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/staging/media/cec/Kconfig b/drivers/staging/media/cec/Kconfig index 21457a1f6c9f..c623bd32a5b8 100644 --- a/drivers/staging/media/cec/Kconfig +++ b/drivers/staging/media/cec/Kconfig @@ -1,6 +1,7 @@ config MEDIA_CEC bool "CEC API (EXPERIMENTAL)" depends on MEDIA_SUPPORT + depends on RC_CORE || !RC_CORE select MEDIA_CEC_EDID ---help--- Enable the CEC API.
We cannot build the cec driver when the RC core is a module and cec is built-in: drivers/staging/built-in.o: In function `cec_allocate_adapter': :(.text+0x134): undefined reference to `rc_allocate_device' drivers/staging/built-in.o: In function `cec_register_adapter': :(.text+0x304): undefined reference to `rc_register_device' This adds an explicit dependency to avoid this case. We still allow building when CONFIG_RC_CORE is disabled completely, as the driver has checks for this case itself. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- I originally submitted this on June 29, but it may have gotten lost as out of the three patch series, one patch got replaced and another patch got applied, but nothing happened on this one. --- drivers/staging/media/cec/Kconfig | 1 + 1 file changed, 1 insertion(+)