From patchwork Tue Jul 19 08:10:13 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 9236329 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 18F99600CB for ; Tue, 19 Jul 2016 08:12:16 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0AE63205AA for ; Tue, 19 Jul 2016 08:12:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F3A7A2094F; Tue, 19 Jul 2016 08:12:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9F3FB205AA for ; Tue, 19 Jul 2016 08:12:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753303AbcGSILg (ORCPT ); Tue, 19 Jul 2016 04:11:36 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:50919 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752620AbcGSIL0 (ORCPT ); Tue, 19 Jul 2016 04:11:26 -0400 Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue104) with ESMTPA (Nemesis) id 0MVd8x-1br7kH0Srv-00Z2sx; Tue, 19 Jul 2016 10:11:18 +0200 From: Arnd Bergmann To: Mauro Carvalho Chehab Cc: Arnd Bergmann , Hans Verkuil , Greg Kroah-Hartman , Kamil Debski , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] [media] cec: add RC_CORE dependency Date: Tue, 19 Jul 2016 10:10:13 +0200 Message-Id: <20160719081040.2685845-2-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20160719081040.2685845-1-arnd@arndb.de> References: <20160719081040.2685845-1-arnd@arndb.de> X-Provags-ID: V03:K0:jMRPBXAMY3k6PCRkch6haawG8sbPT2437KQ9KKSJoF1wvbr2ZPs sdJrL6I5teHA9dBvHkW6yiaRAicfbLugaNFCLVZgwEt6ds63fxUFJhly71B0Achj92QzRQW LZyuI9P/xkquUiK6hIJ1jZKSBwLbcSrlf2SFQhuu4ljRolXYers/HJo1fw3TDSfBT/vMahY 9Sgwd8rxLVO19KIXaYROA== X-UI-Out-Filterresults: notjunk:1; V01:K0:WE26nxFhpRQ=:kzAjHkR5FFmSP31uwJ66ID excveYaa8JZNQX6GMtQwcN/LYygGShQobzvSy2beG1HOUG5vo+b2ocfoE73UUGHrJSqHbofZH 0H8HD8KC8X2RV3Z2youlmuRbJ4SdunWQR00vnc64w+Xr4q2ttHvid3nd42NCWRV6317hnWdxt 7R9wEzroSpY1uyfY39OYb4iVcNsJU4PiPVj6sv0SCwmrsmXDp4orjSs4CzspC3YsenqZTX6uj qtJZW7Qnxg2YCj3EgMZxKpfqUob3GOJf+8Pxt6PiG9cbmQxdlUWplVFXo3yAAHpUE4jgrq4Ya dK/nvfFVBXYpw3eBto/PtFA1r12aQoYnUhFvAJ2D/nBs4CaFtzvbo94qxfbY0Xlf0Yml63PAT oMk04ikc6HXYyEr0cqmhVQ/0Z9L7mvO64k2IPREdKtdssGhYJaPz+0p0O00i/bfjnsDVegZk7 SwyviQc62RQENqG3fCHy/+N+ETmxSAwDwIH8q61Zc9rMHbRIqD2Xm94Wh8xoiXh0gR5QbsPY7 yuzDPw37oGyLpqjV00qbAudCdxUDadik4xuXr5GS6monFv6adJ1415dRq056lbt95NSqatSoW Hp4Sq7YAk9yUJMqABHlATJBcvvNYm0dOhh6aUgQIvUKg+vNUYD4P1IdC/NbhWyKKITq6CkiIK WuSWlxuqulwBcFGo1lQMQJyy30nTrGkDYCvoLp0+GYrYt4yld9fdH3FnfE/6XFciDgjc= Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP We cannot build the cec driver when the RC core is a module and cec is built-in: drivers/staging/built-in.o: In function `cec_allocate_adapter': :(.text+0x134): undefined reference to `rc_allocate_device' drivers/staging/built-in.o: In function `cec_register_adapter': :(.text+0x304): undefined reference to `rc_register_device' This adds an explicit dependency to avoid this case. We still allow building when CONFIG_RC_CORE is disabled completely, as the driver has checks for this case itself. Signed-off-by: Arnd Bergmann --- I originally submitted this on June 29, but it may have gotten lost as out of the three patch series, one patch got replaced and another patch got applied, but nothing happened on this one. --- drivers/staging/media/cec/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/media/cec/Kconfig b/drivers/staging/media/cec/Kconfig index 21457a1f6c9f..c623bd32a5b8 100644 --- a/drivers/staging/media/cec/Kconfig +++ b/drivers/staging/media/cec/Kconfig @@ -1,6 +1,7 @@ config MEDIA_CEC bool "CEC API (EXPERIMENTAL)" depends on MEDIA_SUPPORT + depends on RC_CORE || !RC_CORE select MEDIA_CEC_EDID ---help--- Enable the CEC API.