From patchwork Mon Sep 12 15:34:57 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 9326845 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2041560839 for ; Mon, 12 Sep 2016 15:35:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 12B9028BF7 for ; Mon, 12 Sep 2016 15:35:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0785C28D79; Mon, 12 Sep 2016 15:35:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7B29928BF7 for ; Mon, 12 Sep 2016 15:35:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933947AbcILPfh (ORCPT ); Mon, 12 Sep 2016 11:35:37 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:63476 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933178AbcILPfc (ORCPT ); Mon, 12 Sep 2016 11:35:32 -0400 Received: from wuerfel.lan. ([78.43.20.153]) by mrelayeu.kundenserver.de (mreue003) with ESMTPA (Nemesis) id 0LiGlL-1bEJEV2fo3-00nRvA; Mon, 12 Sep 2016 17:35:24 +0200 From: Arnd Bergmann To: Felipe Balbi , Greg Kroah-Hartman Cc: linux-media@vger.kernel.org, Mauro Carvalho Chehab , Arnd Bergmann , Nicholas Bellinger , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] usb: gadget: uvc: add V4L2 dependency Date: Mon, 12 Sep 2016 17:34:57 +0200 Message-Id: <20160912153521.3136533-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:bckUg9ZkED5fJTR4DkY6DuzVl1u5WZ+ntdujAnM96oIiFwz4VRS Qo7hzZq+rhakVBoDu/iwO/YB3dMx5zAOEe8uf/mtu0VmoJPpd/94losTJSDYBwqHypRh7/e TEIqWSzeVOYuWoE6QrVOcuvm5zCD+t3+PFRZxjp5fNn8oBPjgL379wZ9w689sMqd68KsOcZ VexMpUS2Z7RSolE6Z/k7A== X-UI-Out-Filterresults: notjunk:1; V01:K0:/o0BtZRuZSo=:MC1GF6mMih2StmdAqQE/4+ 6OwtSIT6PMcRH3Bm4Tn3bXpXzgnmhzXcfz/+n5aZeLiMYMTaOPQMTAQHNxgDilWnfDYj7VhxP /Yv97iukckf4CrSbPLFIFzBXzhlHGtoRlqTtgluv4uRqu4fjnkrCxbl9kdi/891SHW//2rrnb 3+kopjaFAAyc61GTXrWbkufTvhHIkfn0EPs/Y+aNAog4uCV9f/kznL6bi9ye0KxMMkcz/CbZh PIbhcAboLtQ9FOtnFLd0etdrr1cTME1h+spbl3ocQTzEUksyr1PHE7Dv1HD/pNzBXmGQEdV8Z PprRH1PjZDyT/vE832Ry+bIU/UUXlogt9vmihLaEyDl+wyuh2yuRp/m3YiTmw87gSxpT3Sd1K +hPoT/upum+S5Hlzdyz1Q/VQJzW1c2/zItftvBFVQAo29g1dNa8LZiMyQkMZdDNplwKmpRNke jax2euYWWiDVZggM5PQZP4qMXGs4zC7pr/CTsCdR0Cq76BjT5vVTCOKSvN2fDydU383RLzudK cDAXL7PFaaSpfgxexool3iD5Hs+uy+9weZK2fQ525rL516N37LzGtRjMZ9rGjGUedo6FqvyPl 8/cQj20VgDimGfTlnN/ijiWRJe2/TK7kWy9D6JeP2RHCz72Yci7iHoeqAUtuuQ5UFbfKmFZJA Kw+o9SMCNcKdA+48GCVJ2RufzWEvCvNWc35TS/h4PQqSNVyrqjx8VdmIRnhZaSb77a5Q= Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Building the UVC gadget into the kernel fails to build when CONFIG_VIDEO_V4L2 is a loadable module: drivers/usb/gadget/function/usb_f_uvc.o: In function `uvc_function_ep0_complete': uvc_configfs.c:(.text.uvc_function_ep0_complete+0x84): undefined reference to `v4l2_event_queue' drivers/usb/gadget/function/usb_f_uvc.o: In function `uvc_function_disable': uvc_configfs.c:(.text.uvc_function_disable+0x34): undefined reference to `v4l2_event_queue' Adding a dependency in USB_CONFIGFS_F_UVC (which is a bool symbol) make the 'select USB_F_UVC' statement turn the USB_F_UVC into 'm' whenever CONFIG_VIDEO_V4L2=m too, avoiding the link failure. Signed-off-by: Arnd Bergmann --- drivers/usb/gadget/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig index 2ea3fc3c41b9..8ad203296079 100644 --- a/drivers/usb/gadget/Kconfig +++ b/drivers/usb/gadget/Kconfig @@ -420,6 +420,7 @@ config USB_CONFIGFS_F_HID config USB_CONFIGFS_F_UVC bool "USB Webcam function" depends on USB_CONFIGFS + depends on VIDEO_V4L2 depends on VIDEO_DEV select VIDEOBUF2_VMALLOC select USB_F_UVC