From patchwork Mon Oct 17 22:19:11 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 9380805 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D538C608A7 for ; Mon, 17 Oct 2016 22:23:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BB67728DEC for ; Mon, 17 Oct 2016 22:23:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id ACA8028D84; Mon, 17 Oct 2016 22:23:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 04B9328D71 for ; Mon, 17 Oct 2016 22:23:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759643AbcJQWWj (ORCPT ); Mon, 17 Oct 2016 18:22:39 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:53153 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759561AbcJQWVk (ORCPT ); Mon, 17 Oct 2016 18:21:40 -0400 Received: from wuerfel.lan. ([78.43.20.153]) by mrelayeu.kundenserver.de (mreue001) with ESMTPA (Nemesis) id 0MWKkb-1cSxZT2VbN-00XO5z; Tue, 18 Oct 2016 00:20:10 +0200 From: Arnd Bergmann To: Linus Torvalds , Michal Marek Cc: linux-kernel@vger.kernel.org, Arnd Bergmann , x86@kernel.org, linux-media@vger.kernel.org, Mauro Carvalho Chehab , Martin Schwidefsky , linux-s390@vger.kernel.org, Ilya Dryomov , dri-devel@lists.freedesktop.org, linux-mtd@lists.infradead.org, Herbert Xu , linux-crypto@vger.kernel.org, "David S. Miller" , netdev@vger.kernel.org, Greg Kroah-Hartman , ceph-devel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-ext4@vger.kernel.org, netfilter-devel@vger.kernel.org, Vineet Gupta , Kees Cook , Ingo Molnar , Josh Poimboeuf , Nicolas Pitre , Andrew Morton , Heiko Carstens , Christian Borntraeger , linux-kbuild@vger.kernel.org, linux-snps-arc@lists.infradead.org Subject: [PATCH 28/28] Kbuild: bring back -Wmaybe-uninitialized warning Date: Tue, 18 Oct 2016 00:19:11 +0200 Message-Id: <20161017222000.1934898-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20161017220342.1627073-1-arnd@arndb.de> References: <20161017220342.1627073-1-arnd@arndb.de> X-Provags-ID: V03:K0:GYmvA3K1oLjK7UXoHztapipCCPCCtyzrfNrLHLiT/+0685FFZKF dH3IsCJiqTeEBVMYyi5pJgjFV4tn5wEHImOOmVECHyMqmlIYMnoWLIRdPiK90r6+B3Dsm3v izALp9869fZrgojChoHBb4LPdAOiKVBXPb+DpCBajSX8fd6688vkOJN07Cr3/LWoWG/fnKV v8tONWRW5l2Mb4u1RsDlQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:Ne+WDpZecMk=:itDvou9YqiactyWFSv9jN0 9Rs44cMqaA4P3qDTSZZYKlmXs/edce0KXcM4sC2SxmlassreU35YzV0BWg6t5I4ePyfcMgac9 KmloFsQZQ9c4DQR2K7Uab9lUaCnPgjxRnNHt4K1GZ/tcDu0H4LTp56p8PKJa/HqaiWr4/IXBQ wAkg9KUz0GQPGJXAEuC676LYz8S6m33fLBrOYwFPF02VlRXXvoU8i8yo7lh1lxoOSo5QgFKiJ RPSuHaQ9BSMjuCiTA7DAoXJiTGlsyIoxquYO5laKXlnudd8oMwwrEbfLLbLToafQ85oRP2yhs JSsu8Yp6eI1KEOa6ON2O5H71yFIKUtlFnl+5FU6uT+EMuvYVitY5CYYncdQwTOXbzaKSNB+QV 7psCMxR5qvkyPXQO4aCpMJWnW9BDh7dG0UbyHqrmS7SAigaU0sd7GEaEzyVDi5vSld3YeyLNP y0mwrUzQD3LY0MCUPQuRHfpmGB7ZQKE39Hkwu0gm2GZcxQJUHUpw2Ohz7TUBdOCjmjk+W3ai0 ec1U8DBSBTZFIcDQ2PhiDkfcnLLx/8KSN8CFFiq0Qi2grQCMxL2sBWQ1iL9hDkqROnzbG5AZx Rc2nKWtFxTFCNNrQD3hMMYCRsbrBI5MTZqQ+fDi0nevRfojk+9zXsgwqikADBDhIcSQQHylL6 QQ4b6TOxQnwo8nR53f7w9vY1FET6jMpDQHH9ykezfDABfaoiXp4DNAt7Kh3V+G8j3aCM= Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Traditionally, we have always had warnings about uninitialized variables enabled, as this is part of -Wall, and generally a good idea [1], but it also always produced false positives, mainly because this is a variation of the halting problem and provably impossible to get right in all cases [2]. Various people have identified cases that are particularly bad for false positives, and in commit e74fc973b6e5 ("Turn off -Wmaybe-uninitialized when building with -Os"), I turned off the warning for any build that was done with CC_OPTIMIZE_FOR_SIZE. This drastically reduced the number of false positive warnings in the default build but unfortunately had the side effect of turning the warning off completely in 'allmodconfig' builds, which in turn led to a lot of warnings (both actual bugs, and remaining false positives) to go in unnoticed. With commit 877417e6ffb9 ("Kbuild: change CC_OPTIMIZE_FOR_SIZE definition") enabled the warning again for allmodconfig builds in v4.7 and in v4.8-rc1, I had finally managed to address all warnings I get in an ARM allmodconfig build and most other maybe-uninitialized warnings for ARM randconfig builds. However, commit 6e8d666e9253 ("Disable "maybe-uninitialized" warning globally") was merged at the same time and disabled it completely for all configurations, because of false-positive warnings on x86 that I had not addressed until then. This caused a lot of actual bugs to get merged into mainline, and I sent several dozen patches for these during the v4.9 development cycle. Most of these are actual bugs, some are for correct code that is safe because it is only called under external constraints that make it impossible to run into the case that gcc sees, and in a few cases gcc is just stupid and finds something that can obviously never happen. I have now done a few thousand randconfig builds on x86 and collected all patches that I needed to address every single warning I got (I can provide the combined patch for the other warnings if anyone is interested), so I hope we can get the warning back and let people catch the actual bugs earlier. Note that the majority of the patches I created are for the third kind of problem (stupid false-positives), for one of two reasons: - some of them only get triggered in certain combinations of config options, so we don't always run into them, and - the actual bugs tend to get addressed much quicker as they also lead to incorrect runtime behavior. These 27 patches address the warnings that either occur in one of the more common configurations (defconfig, allmodconfig, or something built by the kbuild robot or kernelci.org), or they are about a real bug. It would be good to get these all into v4.9 if we want to turn on the warning again. I have tested these extensively with gcc-4.9 and gcc-6 and done a bit of testing with gcc-5, and all of these should now be fine. gcc-4.8 is much worse about the false-positive warnings and is also fairly old now, so I'm leaving the warning disabled with that version. gcc-4.7 and older don't understand the -Wno-maybe-uninitialized option and are not affected by this patch either way. I have another (smaller) series of patches for warnings that are both harmless and not as easy to trigger, and I will send them for inclusion in v4.10. Link: https://rusty.ozlabs.org/?p=232 [1] Link: https://gcc.gnu.org/wiki/Better_Uninitialized_Warnings [2] Signed-off-by: Arnd Bergmann --- Makefile | 10 ++++++---- arch/arc/Makefile | 4 +++- scripts/Makefile.ubsan | 4 ++++ 3 files changed, 13 insertions(+), 5 deletions(-) Cc: x86@kernel.org Cc: linux-media@vger.kernel.org Cc: Mauro Carvalho Chehab Cc: Martin Schwidefsky Cc: linux-s390@vger.kernel.org Cc: Ilya Dryomov Cc: dri-devel@lists.freedesktop.org Cc: linux-mtd@lists.infradead.org Cc: Herbert Xu Cc: linux-crypto@vger.kernel.org Cc: "David S. Miller" Cc: netdev@vger.kernel.org Cc: Greg Kroah-Hartman Cc: ceph-devel@vger.kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net Cc: linux-ext4@vger.kernel.org Cc: netfilter-devel@vger.kernel.org diff --git a/Makefile b/Makefile index 512e47a..43cd3d9 100644 --- a/Makefile +++ b/Makefile @@ -370,7 +370,7 @@ LDFLAGS_MODULE = CFLAGS_KERNEL = AFLAGS_KERNEL = LDFLAGS_vmlinux = -CFLAGS_GCOV = -fprofile-arcs -ftest-coverage -fno-tree-loop-im +CFLAGS_GCOV = -fprofile-arcs -ftest-coverage -fno-tree-loop-im -Wno-maybe-uninitialized CFLAGS_KCOV := $(call cc-option,-fsanitize-coverage=trace-pc,) @@ -620,7 +620,6 @@ ARCH_CFLAGS := include arch/$(SRCARCH)/Makefile KBUILD_CFLAGS += $(call cc-option,-fno-delete-null-pointer-checks,) -KBUILD_CFLAGS += $(call cc-disable-warning,maybe-uninitialized,) KBUILD_CFLAGS += $(call cc-disable-warning,frame-address,) ifdef CONFIG_LD_DEAD_CODE_DATA_ELIMINATION @@ -629,15 +628,18 @@ KBUILD_CFLAGS += $(call cc-option,-fdata-sections,) endif ifdef CONFIG_CC_OPTIMIZE_FOR_SIZE -KBUILD_CFLAGS += -Os +KBUILD_CFLAGS += -Os $(call cc-disable-warning,maybe-uninitialized,) else ifdef CONFIG_PROFILE_ALL_BRANCHES -KBUILD_CFLAGS += -O2 +KBUILD_CFLAGS += -O2 $(call cc-disable-warning,maybe-uninitialized,) else KBUILD_CFLAGS += -O2 endif endif +KBUILD_CFLAGS += $(call cc-ifversion, -lt, 0409, \ + $(call cc-disable-warning,maybe-uninitialized,)) + # Tell gcc to never replace conditional load with a non-conditional one KBUILD_CFLAGS += $(call cc-option,--param=allow-store-data-races=0) diff --git a/arch/arc/Makefile b/arch/arc/Makefile index aa82d13..19cce22 100644 --- a/arch/arc/Makefile +++ b/arch/arc/Makefile @@ -71,7 +71,9 @@ cflags-$(CONFIG_ARC_DW2_UNWIND) += -fasynchronous-unwind-tables $(cfi) ifndef CONFIG_CC_OPTIMIZE_FOR_SIZE # Generic build system uses -O2, we want -O3 # Note: No need to add to cflags-y as that happens anyways -ARCH_CFLAGS += -O3 +# +# Disable the false maybe-uninitialized warings gcc spits out at -O3 +ARCH_CFLAGS += -O3 $(call cc-disable-warning,maybe-uninitialized,) endif # small data is default for elf32 tool-chain. If not usable, disable it diff --git a/scripts/Makefile.ubsan b/scripts/Makefile.ubsan index dd779c4..3b1b138 100644 --- a/scripts/Makefile.ubsan +++ b/scripts/Makefile.ubsan @@ -17,4 +17,8 @@ endif ifdef CONFIG_UBSAN_NULL CFLAGS_UBSAN += $(call cc-option, -fsanitize=null) endif + + # -fsanitize=* options makes GCC less smart than usual and + # increase number of 'maybe-uninitialized false-positives + CFLAGS_UBSAN += $(call cc-option, -Wno-maybe-uninitialized) endif