From patchwork Wed Nov 23 11:37:11 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vincent McIntyre X-Patchwork-Id: 9443025 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1DAD5600BA for ; Wed, 23 Nov 2016 11:37:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EAF801FEBD for ; Wed, 23 Nov 2016 11:37:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DEAAC208C2; Wed, 23 Nov 2016 11:37:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6767B1FEBD for ; Wed, 23 Nov 2016 11:37:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934961AbcKWLhY (ORCPT ); Wed, 23 Nov 2016 06:37:24 -0500 Received: from mail-pg0-f65.google.com ([74.125.83.65]:34805 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756305AbcKWLhX (ORCPT ); Wed, 23 Nov 2016 06:37:23 -0500 Received: by mail-pg0-f65.google.com with SMTP id e9so950270pgc.1 for ; Wed, 23 Nov 2016 03:37:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:mime-version:content-disposition :user-agent; bh=DbVkuyc/6a9mzzWkmF+0cTIL6CCAlLFUrO4clfksLoo=; b=ssVqBPMbQ1lIMyW9dEgtiREBdebyKdVr8HKReKMsWzpaieJPWAau1AXqOC7SsuHSTJ t5vuCNj/v8BYMbOhqpbmf8+u0UsT2wkhw39K/jfdFQYvsADiCzP++CfGRHT1UlgnnThP 5DZlwbEUQrTofSMvK2QQ5uQe/Ihn+h3VToQKDQXWgRZMqvbAUhN6sO1opZEpXk8P19mR hTdUxwVuEyuOs+fdQIxL9d0ucEYBs8DxpjKXWyCyR4254q591ev8jIAfQ7iM8TqTVQ7a O9KhrnJmPlkREnVbdTHnSuYXiD2+OFTsdWYD1D3v43tTIZSZLqgu5CjlJkSnJGFfK/QB 8/+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:user-agent; bh=DbVkuyc/6a9mzzWkmF+0cTIL6CCAlLFUrO4clfksLoo=; b=fwcUxHYFG165si2yfdq5BUzxGIeLVlDTchCnVIKq2tjuuNrkofjsBcrVZwSv1bYrgA 0AqJk5X+yvPu6cZyKFIrJsgEJOZBvkQaoKXNW+OlMcbmoPKF5yUEegwK4U8JL8ta+xor q7n1Wx4sWdsLOmY+rZtSnaKO55WbtsyiEJfmjck2SjXK0ZOC6iiClLjUAXiYG1Itj3ax 6/wzxiW5ZzytunOfYKA0dbe9JZsmXuLnSuIEGrr6xR7ePFm+DEDJGVXFfXODxTw9km0Y OM7yIGdDF2J0cktFVgj2C0Wg5GvXn+FJgy64eyBQ8tqgijIJuDVKlqqEiLDQwZKmed7O eK+g== X-Gm-Message-State: AKaTC00H95/0vkqHQLAek7GS7cJewqij7S9it2+0Taz5XOaBPTChwMi06SV01TEj8VqJSA== X-Received: by 10.98.14.82 with SMTP id w79mr2319954pfi.153.1479901042466; Wed, 23 Nov 2016 03:37:22 -0800 (PST) Received: from shambles.local (c122-106-153-7.carlnfd1.nsw.optusnet.com.au. [122.106.153.7]) by smtp.gmail.com with ESMTPSA id b12sm49957640pfb.78.2016.11.23.03.37.20 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 Nov 2016 03:37:21 -0800 (PST) Date: Wed, 23 Nov 2016 22:37:11 +1100 From: Vincent McIntyre To: linux-media@vger.kernel.org Subject: [patch] fix 'make install' Message-ID: <20161123113709.GA14257@shambles.local> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Recent work on handling the case of no frame_vector.c in the kernel seems to have ended up breaking the 'make install' target. The patch below makes it work again for me, on ubuntu 16.04 LTS, amd64, kernel 4.4. Without it, I get this behavior: moake -C /home/me/media_build/v4l install make[1]: Entering directory '/home/me/media_build/v4l' make[1]: *** No rule to make target 'mm-install', needed by 'install'. Stop. make[1]: Leaving directory '/home/me/media_build/v4l' Makefile:15: recipe for target 'install' failed make: *** [install] Error 2 Vince --- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/v4l/Makefile b/v4l/Makefile index 28e8fb7..74a2633 100644 --- a/v4l/Makefile +++ b/v4l/Makefile @@ -210,8 +210,14 @@ all:: default ################################################# # installation invocation rules - -modules_install install:: mm-install media-install firmware_install +INSTALLDEPS := +ifeq ($(makefile-mm),1) +INSTALLDEPS += mm-install +endif +ifeq ($(makefile-media),1) +INSTALLDEPS += media-install +endif +modules_install install:: $(INSTALLDEPS) firmware_install remove rminstall:: media-rminstall