From patchwork Thu Feb 2 12:15:32 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 9551723 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id AFDA360405 for ; Thu, 2 Feb 2017 12:17:16 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A823F280CF for ; Thu, 2 Feb 2017 12:17:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9C4F828425; Thu, 2 Feb 2017 12:17:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 330AE280CF for ; Thu, 2 Feb 2017 12:17:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751414AbdBBMQp (ORCPT ); Thu, 2 Feb 2017 07:16:45 -0500 Received: from mout.kundenserver.de ([212.227.17.13]:51332 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751073AbdBBMQo (ORCPT ); Thu, 2 Feb 2017 07:16:44 -0500 Received: from wuerfel.lan ([78.42.17.5]) by mrelayeu.kundenserver.de (mreue102 [212.227.15.145]) with ESMTPA (Nemesis) id 0LfRYv-1c6W8v49ub-00p0np; Thu, 02 Feb 2017 13:16:01 +0100 From: Arnd Bergmann To: Greg Kroah-Hartman Cc: Arnd Bergmann , Mauro Carvalho Chehab , Stephen Warren , Lee Jones , Eric Anholt , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] staging: bcm2835: don't mark 'bcm2835_v4l2_debug' as static Date: Thu, 2 Feb 2017 13:15:32 +0100 Message-Id: <20170202121554.1265939-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:TGI0wZz6BGb9Ep//am/ZDGRCz9o/HLe0VWqk/zd632uDyeRubYl NoeYa5OH7L1w0wat50mE6niA9jZsxJTaR+spTlkPwMBSosU0BKBerhfP+QPZqxRZsD+wXlr qWZTSOX70IPxkIztDo+R2QCjv5POFHdXfhCpUrS1hTgRoAs6OMoxgFJUhDc8LdeUFwPaqV7 Jccx5zxhBn2KpB9SjZorg== X-UI-Out-Filterresults: notjunk:1; V01:K0:bUGrXqytVdU=:ek2+eI82LoZaWhm6th/FJd 5tGT85rhiZF6gyDXKx2e9LELqQJKah37r6Mbs9UmenHFfwdu4u4FwEH9p8bn1GJW7Cp6bUh5/ A/fdTMBeUMgfPjSUoW9DfRxFjf9VnJS/a5VY6uVXAstrqjjDHWOVfVTVeZ/6Sw1o55l3OXrzQ NKN4PnmVaMoxyVHUEw9ojVQVvhn1V1eUaJocudS9ClV4Ibh8hVGKoABIUGNWSF8MFDjOM70Xr n0ZvDtwe0d+ZoIDE48JImAUssBKrStQ+7vUF2NoQKvfd3YJfagF+Nq+8J8xrRWpCPYCiKV45I nK30wgoH/9fKueJsy5s2l/eZBdOy9HvUn7M1ShBUAy+47DaafljshlFpnDNQVdMqrQpvA96CN x6qOcIglZD8TiUXTSx1W9G7Nuyr6F3mSB9laA2EkPz0ogZj7SCutgrGLakU4tQFuluf4qNHI1 HoxQZ/tykwzGdcc48crCr3X7dYaK4apgjTZwPmEAyiJ6WObn3L90vYj9kzWwSVuyC8e78XnJS Mb9rrFMZ+qd1IbbYd2Oo+g9pJEYGBScSSMBUVvfm+FJrUzqAuUOAaq7RXhMd+2fJPMTgvlG7I ZQw/xcZpT9aEy/jA8p9XjTDgw8mKKGvGQjoDk3QgAnQ8VgEPKXenrMO9Sovpkn3waZIYywZTE GQWsI2M4dhSx0osmNtEklWpSOfQ5Ykz2VPHxwvc7Cpro/fUr3zeFzuZjo9RNb8di5cSc= Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This one unfortunately slipped through my own build testing, my patch caused a new build error: bcm2835-camera.c:53:12: error: static declaration of 'bcm2835_v4l2_debug' follows non-static declaration We want the symbol to be global as it is indeed used in more than one file and declared 'extern' in a header. Fixes: 757b9bd074 ("staging: bcm2835: mark all symbols as 'static'") Signed-off-by: Arnd Bergmann --- drivers/staging/media/platform/bcm2835/bcm2835-camera.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/platform/bcm2835/bcm2835-camera.c b/drivers/staging/media/platform/bcm2835/bcm2835-camera.c index ced8eb5de0f0..ca15a698e018 100644 --- a/drivers/staging/media/platform/bcm2835/bcm2835-camera.c +++ b/drivers/staging/media/platform/bcm2835/bcm2835-camera.c @@ -50,7 +50,7 @@ MODULE_AUTHOR("Vincent Sanders"); MODULE_LICENSE("GPL"); MODULE_VERSION(BM2835_MMAL_VERSION); -static int bcm2835_v4l2_debug; +int bcm2835_v4l2_debug; module_param_named(debug, bcm2835_v4l2_debug, int, 0644); MODULE_PARM_DESC(bcm2835_v4l2_debug, "Debug level 0-2");