| Message ID | 20170320093225.1180723-3-arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, 20 Mar 2017 10:32:19 +0100 Arnd Bergmann <arnd@arndb.de> wrote: > -void ia_css_dequeue_param_buffers(/*unsigned int pipe_num*/) > +void ia_css_dequeue_param_buffers(/*unsigned int pipe_num*/ void) > { Why keep the comment?
On Mon, Mar 20, 2017 at 4:05 PM, Stephen Hemminger <stephen@networkplumber.org> wrote: > On Mon, 20 Mar 2017 10:32:19 +0100 > Arnd Bergmann <arnd@arndb.de> wrote: > >> -void ia_css_dequeue_param_buffers(/*unsigned int pipe_num*/) >> +void ia_css_dequeue_param_buffers(/*unsigned int pipe_num*/ void) >> { > Why keep the comment? The comment matches one later in the file when this function gets called. I thought about cleaning up both at the same time, but couldn't figure out how the comment ended up in there or why it was left behind in the first place, so I ended up leaving both for another patch on top. If you prefer, I could resend the patch and do both at once. Arnd
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c b/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c index 9d51f1c653a2..1f346394c6b1 100644 --- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c +++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c @@ -3725,7 +3725,7 @@ static void sh_css_update_isp_mem_params_to_ddr( IA_CSS_LEAVE_PRIVATE("void"); } -void ia_css_dequeue_param_buffers(/*unsigned int pipe_num*/) +void ia_css_dequeue_param_buffers(/*unsigned int pipe_num*/ void) { unsigned int i; hrt_vaddress cpy;
ia_css_dequeue_param_buffers does not have an arguement type, causing a warning: drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c: In function 'ia_css_dequeue_param_buffers': drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c:3728:6: error: old-style function definition [-Werror=old-style-definition] This adds a 'void' keywork to silence the warning. Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)