From patchwork Sun Apr 16 17:35:40 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Frank_Sch=C3=A4fer?= X-Patchwork-Id: 9683045 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 172A360389 for ; Sun, 16 Apr 2017 17:36:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 064B0279E0 for ; Sun, 16 Apr 2017 17:36:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EF17227BFF; Sun, 16 Apr 2017 17:36:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 932E627BFF for ; Sun, 16 Apr 2017 17:36:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756538AbdDPRf7 (ORCPT ); Sun, 16 Apr 2017 13:35:59 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:32782 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756293AbdDPRf6 (ORCPT ); Sun, 16 Apr 2017 13:35:58 -0400 Received: by mail-wm0-f67.google.com with SMTP id o81so5886338wmb.0 for ; Sun, 16 Apr 2017 10:35:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ueYhDmVDdeatTlA6P6q343dWck/ZGv5o9dw2D/6Mw/Y=; b=YjI1o3IAJceSMUnad2HshYp0kfy2wzYkQpd75HbknKZ/6rLBObSkP0fz4ooNKgnJmW tpCUfYyPN+ojJOzA/dG2wXHDd7J2uWSTWd70El9DaGXxJdX6wwEpbxiHFo5eLJT4mFaj axOejLQdmk0skPnqFBnqv98wvsrCQLx9dWw5c/FoAhsaTpTQZ/8uD7lp0Zq0VHyQ8uRT K1EP0EdPfHsFXedxn6Sa2gEPSUWGJRSjwN4/T6theITfeP14jIjnculc96B6wCTJPNlE UZg0wus77Tj20pWZoXg7KKrrWlMaBqlE3wo0NOVYCak/Fgj0eyOO4MByCsmXr9svg/pj 6t0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ueYhDmVDdeatTlA6P6q343dWck/ZGv5o9dw2D/6Mw/Y=; b=G/Az+MvhwcPIOoxqySdOT30VbeNRDfdOav2mgkovz2BAdPYGKH1z3W//fE6Zh5OFtt oKrbUwxAIzmzstVglUy3pIxS7jlP5caaCwh7+TW7kuyPIOQrMl/vr4X7bWqnW/WpZVs9 XJ01llgwBndOr464gCGJW0wGVBOsPkzeW0wW9fafXVk1HLjUJKcdHbOxv58pWSmh14bZ NPVr4plLz990vRszF0vZtYU/00mYWAS2vBEkmgmFwa4o0J0mumiyhPOg8x0R/vVt4zGx YaOrXQ3OFVcG0jMX9JG5UY4yppX6CZSwX6dhO2BkQZslsD0yLvcmj452/u3ReKxlNIEd H9EQ== X-Gm-Message-State: AN3rC/6L1oyfQf980uLY6MIgDvKAv3atpPA3p01u6bBWdq1wfIaICYNT VVXjeNsYTDa74X6e X-Received: by 10.28.109.81 with SMTP id i78mr5712129wmc.127.1492364156872; Sun, 16 Apr 2017 10:35:56 -0700 (PDT) Received: from Athlon64X2-5000.lan (ip-109-90-213-36.hsi11.unitymediagroup.de. [109.90.213.36]) by smtp.googlemail.com with ESMTPSA id l36sm8491642wrl.59.2017.04.16.10.35.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 16 Apr 2017 10:35:55 -0700 (PDT) From: =?UTF-8?q?Frank=20Sch=C3=A4fer?= To: linux-media@vger.kernel.org Cc: guennadi.liakhovetski@intel.com, hans.verkuil@cisco.com, =?UTF-8?q?Frank=20Sch=C3=A4fer?= Subject: [PATCH 1/7] ov2640: fix init sequence alignment Date: Sun, 16 Apr 2017 19:35:40 +0200 Message-Id: <20170416173546.4317-2-fschaefer.oss@googlemail.com> X-Mailer: git-send-email 2.12.2 In-Reply-To: <20170416173546.4317-1-fschaefer.oss@googlemail.com> References: <20170416173546.4317-1-fschaefer.oss@googlemail.com> MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP While we are at it, remove a misleading comment (copy/paste mistake) Signed-off-by: Frank Schäfer --- drivers/media/i2c/ov2640.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/media/i2c/ov2640.c b/drivers/media/i2c/ov2640.c index d55ca37dc12f..df9f6c7a929c 100644 --- a/drivers/media/i2c/ov2640.c +++ b/drivers/media/i2c/ov2640.c @@ -199,7 +199,7 @@ #define COM7_ZOOM_EN 0x04 /* Enable Zoom mode */ #define COM7_COLOR_BAR_TEST 0x02 /* Enable Color Bar Test Pattern */ #define COM8 0x13 /* Common control 8 */ -#define COM8_DEF 0xC0 /* Banding filter ON/OFF */ +#define COM8_DEF 0xC0 #define COM8_BNDF_EN 0x20 /* Banding filter ON/OFF */ #define COM8_AGC_EN 0x04 /* AGC Auto/Manual control selection */ #define COM8_AEC_EN 0x01 /* Auto/Manual Exposure control */ @@ -306,11 +306,11 @@ static const struct regval_list ov2640_init_regs[] = { { 0x2e, 0xdf }, { BANK_SEL, BANK_SEL_SENS }, { 0x3c, 0x32 }, - { CLKRC, CLKRC_DIV_SET(1) }, - { COM2, COM2_OCAP_Nx_SET(3) }, - { REG04, REG04_DEF | REG04_HREF_EN }, - { COM8, COM8_DEF | COM8_BNDF_EN | COM8_AGC_EN | COM8_AEC_EN }, - { COM9, COM9_AGC_GAIN_8x | 0x08}, + { CLKRC, CLKRC_DIV_SET(1) }, + { COM2, COM2_OCAP_Nx_SET(3) }, + { REG04, REG04_DEF | REG04_HREF_EN }, + { COM8, COM8_DEF | COM8_BNDF_EN | COM8_AGC_EN | COM8_AEC_EN }, + { COM9, COM9_AGC_GAIN_8x | 0x08}, { 0x2c, 0x0c }, { 0x33, 0x78 }, { 0x3a, 0x33 }, @@ -355,25 +355,25 @@ static const struct regval_list ov2640_init_regs[] = { { 0x71, 0x94 }, { 0x73, 0xc1 }, { 0x3d, 0x34 }, - { COM7, COM7_RES_UXGA | COM7_ZOOM_EN }, + { COM7, COM7_RES_UXGA | COM7_ZOOM_EN }, { 0x5a, 0x57 }, { BD50, 0xbb }, { BD60, 0x9c }, - { BANK_SEL, BANK_SEL_DSP }, + { BANK_SEL, BANK_SEL_DSP }, { 0xe5, 0x7f }, - { MC_BIST, MC_BIST_RESET | MC_BIST_BOOT_ROM_SEL }, + { MC_BIST, MC_BIST_RESET | MC_BIST_BOOT_ROM_SEL }, { 0x41, 0x24 }, - { RESET, RESET_JPEG | RESET_DVP }, + { RESET, RESET_JPEG | RESET_DVP }, { 0x76, 0xff }, { 0x33, 0xa0 }, { 0x42, 0x20 }, { 0x43, 0x18 }, { 0x4c, 0x00 }, - { CTRL3, CTRL3_BPC_EN | CTRL3_WPC_EN | 0x10 }, + { CTRL3, CTRL3_BPC_EN | CTRL3_WPC_EN | 0x10 }, { 0x88, 0x3f }, { 0xd7, 0x03 }, { 0xd9, 0x10 }, - { R_DVP_SP , R_DVP_SP_AUTO_MODE | 0x2 }, + { R_DVP_SP, R_DVP_SP_AUTO_MODE | 0x2 }, { 0xc8, 0x08 }, { 0xc9, 0x80 }, { BPADDR, 0x00 },