From patchwork Thu Aug 24 22:22:28 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 9921059 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 83560603FA for ; Thu, 24 Aug 2017 22:23:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7767F1FFF9 for ; Thu, 24 Aug 2017 22:23:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6BA931FFF8; Thu, 24 Aug 2017 22:23:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id ED80C1FFCA for ; Thu, 24 Aug 2017 22:23:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754090AbdHXWWt (ORCPT ); Thu, 24 Aug 2017 18:22:49 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:62159 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753428AbdHXWWs (ORCPT ); Thu, 24 Aug 2017 18:22:48 -0400 Received: from wuerfel.lan ([95.208.190.237]) by mrelayeu.kundenserver.de (mreue005 [212.227.15.129]) with ESMTPA (Nemesis) id 0LhRY4-1dGMaZ1aHA-00mYsb; Fri, 25 Aug 2017 00:22:43 +0200 From: Arnd Bergmann To: Mauro Carvalho Chehab Cc: Arnd Bergmann , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] [media] au0828: fix RC_CORE dependency Date: Fri, 25 Aug 2017 00:22:28 +0200 Message-Id: <20170824222242.788086-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:aRsK9yHIyyK1e+PGiY8HiiI/uXgj3fLbIwzlp0ma6u862JQRMqq NIjx0vnACD/EWx9/sVYOhawQhP+SjNzPhJih1nplK4IaGSon8LPdqxwccJZEEtNJhlsvI19 qagYP8zwwOHcOGvtvlzNkqm0VO5ZyL59D4lcgHAOuOtlxgJWAr1B697noB+6ULyPMz4bAfJ 2yB17+HrskB7fv7YCNmsg== X-UI-Out-Filterresults: notjunk:1; V01:K0:fGtNGuiBLpw=:g+gBEkKsj+47x85a37yvNA 0lFZ6zRRiHpqiE6xbpXlS/7rn8FkBTwPMxBPcvlhz7LpC1KHpuku0yZOmBXaeiodL4TBH3QYk kQSu2FnbOGcn69JAutETeRnpFKLZZ7bl4lpJEfuvvdwUmy8NtsLeTfnVZnEaCNGo+QZRoRnX3 3muTOgRhZrsvjnvB7vhK+Dc7eYAAbVqyc9eaV7Mv+f+hRLO4puKGlSuEQNixP78y8f+9D/lph zNq2ltZ9VXa9e2Q1Y8WO4Oxg+uIEzH/bxT4aPsihEPbGKH5pcM2YczLXqRdkIBd+mbPUwsmO2 biukSRDnLHUh3fP5By3A6TTSkcQgpqOAFRp76xA8sLw/mwnQrr6NdvTE1pePawMhAr6anh9aY xDx/4qvSl2W2LpcYFe6SvW59XDRLh8bjmeTrxP7AUtEHQDDSSvjMz7Q60/yIdmuLyH8uIZPxF qj4KScyHzJDz0Rcj4Vy/t9lCrMw5eeHOMXirqV8jjPL9DIlzcVKqjouUmqwZpfIK+p+RRcxn2 zUc715LtXoYcmKZ4TqwPhTEDRq33PjVvyROZXr9E4lD3cOwV6ID8GM4KJ6Nny6+6s0ZrcIosn uqn+km092PczJX+LPh9Awny8tZmrMgQYsWBsBC9NxFeusMgYEMhbsx9s6FyVtVvaqoPM4+X41 /a4hOkABMAywoNHAp9k0PeKU9ExjUaWgTUBIH/8fKSFlvQHbnqgUk7Q0w+G8DdvRoa1C5Xa/m p8RuA/hHqZJt6a3CxUO5m/8xvgo+4P6vWoIXaw== Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When RC_CORE is a loadable module, and au0828 is built-in including the RC support, we get a link error: drivers/media/usb/au0828/au0828-input.o: In function `au0828_get_key_au8522': au0828-input.c:(.text+0x474): undefined reference to `ir_raw_event_store' drivers/media/usb/au0828/au0828-input.o: In function `au0828_rc_register': au0828-input.c:(.text+0x7c8): undefined reference to `rc_allocate_device' au0828-input.c:(.text+0x8f8): undefined reference to `rc_register_device' This adds an additional dependency, similar to the one for em28xx, to ensure the broken configuration is never used. Fixes: 2fcfd317f66c ("[media] au0828: add support for IR on HVR-950Q") Signed-off-by: Arnd Bergmann --- drivers/media/usb/au0828/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/usb/au0828/Kconfig b/drivers/media/usb/au0828/Kconfig index 78b797e0b434..70521e0b4c53 100644 --- a/drivers/media/usb/au0828/Kconfig +++ b/drivers/media/usb/au0828/Kconfig @@ -31,6 +31,7 @@ config VIDEO_AU0828_V4L2 config VIDEO_AU0828_RC bool "AU0828 Remote Controller support" depends on RC_CORE + depends on !(RC_CORE=m && VIDEO_AU0828=y) depends on VIDEO_AU0828 ---help--- Enables Remote Controller support on au0828 driver.