| Message ID | 20171128103841.490119-1-arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Nov 28, 2017 at 11:38:00AM +0100, Arnd Bergmann wrote: > v4l2_async_register_subdev_sensor_common() is only provided when > CONFIG_V4L2_FWNODE is enabled, otherwise we get a link failure: > > drivers/media/i2c/ov13858.o: In function `ov13858_probe': > ov13858.c:(.text+0xf74): undefined reference to `v4l2_async_register_subdev_sensor_common' > > This adds a Kconfig 'select' statement like all the other users of > this interface have. > > Fixes: 2e8a9fbb7950 ("media: ov13858: Add support for flash and lens devices") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > This is the same patch I submitted for et8ek8 earlier. Both > are needed for 4.15. Hi Arnd, Thanks for the patch. There's already a patch with the same change queued up, so I'll use that instead.
diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig index 3c6d6428f525..cb5d7ff82915 100644 --- a/drivers/media/i2c/Kconfig +++ b/drivers/media/i2c/Kconfig @@ -676,6 +676,7 @@ config VIDEO_OV13858 tristate "OmniVision OV13858 sensor support" depends on I2C && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API depends on MEDIA_CAMERA_SUPPORT + select V4L2_FWNODE ---help--- This is a Video4Linux2 sensor-level driver for the OmniVision OV13858 camera.
v4l2_async_register_subdev_sensor_common() is only provided when CONFIG_V4L2_FWNODE is enabled, otherwise we get a link failure: drivers/media/i2c/ov13858.o: In function `ov13858_probe': ov13858.c:(.text+0xf74): undefined reference to `v4l2_async_register_subdev_sensor_common' This adds a Kconfig 'select' statement like all the other users of this interface have. Fixes: 2e8a9fbb7950 ("media: ov13858: Add support for flash and lens devices") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- This is the same patch I submitted for et8ek8 earlier. Both are needed for 4.15. --- drivers/media/i2c/Kconfig | 1 + 1 file changed, 1 insertion(+)