@@ -299,7 +299,7 @@ static enum csi_output_fmt get_csi_output_format(struct sun6i_csi_dev *sdev,
return buf_interlaced ? CSI_FRAME_PLANAR_YUV422 :
CSI_FIELD_PLANAR_YUV422;
default:
- WARN(1, "Unsupported pixformat: 0x%x\n", pixformat);
+ dev_warn(sdev->dev, "Unsupported pixformat: 0x%x\n", pixformat);
break;
}
@@ -330,7 +330,8 @@ static enum csi_input_seq get_csi_input_seq(struct sun6i_csi_dev *sdev,
case MEDIA_BUS_FMT_YVYU8_2X8:
return CSI_INPUT_SEQ_YVYU;
default:
- WARN(1, "Unsupported mbus code: 0x%x\n", mbus_code);
+ dev_warn(sdev->dev, "Unsupported mbus code: 0x%x\n",
+ mbus_code);
break;
}
break;
@@ -351,12 +352,14 @@ static enum csi_input_seq get_csi_input_seq(struct sun6i_csi_dev *sdev,
case MEDIA_BUS_FMT_YVYU8_2X8:
return CSI_INPUT_SEQ_YUYV;
default:
- WARN(1, "Unsupported mbus code: 0x%x\n", mbus_code);
+ dev_warn(sdev->dev, "Unsupported mbus code: 0x%x\n",
+ mbus_code);
break;
}
break;
default:
- WARN(1, "Unsupported pixformat: 0x%x\n", pixformat);
+ dev_warn(sdev->dev, "Unsupported pixformat: 0x%x, defaulting to YUYV\n",
+ pixformat);
break;
}
Currently the driver will call WARN when a format isn't available, resulting in a kernel backtrace in our logs. This makes it look much more serious than it should be. Replace the call to the WARN macro to a dev_warn, which will still allow us to log what happened without making it too dramatic. Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com> --- drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-)