From patchwork Wed Mar 7 14:02:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mauro Carvalho Chehab X-Patchwork-Id: 10264125 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 21B2560247 for ; Wed, 7 Mar 2018 14:02:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 11AFB289F3 for ; Wed, 7 Mar 2018 14:02:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 055E328A34; Wed, 7 Mar 2018 14:02:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B8B23289F3 for ; Wed, 7 Mar 2018 14:02:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933489AbeCGOCi (ORCPT ); Wed, 7 Mar 2018 09:02:38 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:40692 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933293AbeCGOCh (ORCPT ); Wed, 7 Mar 2018 09:02:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Sender:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Rtxz2iaHiAq3P6GKcz2BJraCT0/ydLfLXfYBTnvEdvE=; b=MHy/aDhQi6p2ZJpOCBbMbSsyv Y2Nhaso2DmwyNxHgui/La5HBWOuCJqFRam7IdX96fJ5rc0ytet1ovLX+bsgkyqzja/LfINTtTvYdx C3mkngRo+1+GxmqmVOg0pk8k7uPMXaOLU2w+nzXlzLsLmpWvDO8PNYWUR9UazkH4U74FVySeHPyX3 xU6Ul+q60wZlHWrTkAF9z9hILTQLn/3YkuLVT969xaive0QjfqOiXJ93wg/V6G89OHXegYaw59Rfq 3WtzV1jkT6TCcq5BMitIyUok6/VQz6WpJBpsSiAyyn2pX/bwL9m/JK5Pfz8daEy9D9vK7fvhj9Tj1 Hepu8G98g==; Received: from 177.43.25.174.dynamic.adsl.gvt.net.br ([177.43.25.174] helo=vento.lan) by bombadil.infradead.org with esmtpsa (Exim 4.89 #1 (Red Hat Linux)) id 1etZeO-00086U-7P; Wed, 07 Mar 2018 14:02:36 +0000 Date: Wed, 7 Mar 2018 11:02:31 -0300 From: Mauro Carvalho Chehab To: Antti Palosaari Cc: Nigel Kettlewell , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Fix for hanging si2168 in PCTV 292e, making the code match Message-ID: <20180307110231.10f5b6ef@vento.lan> In-Reply-To: References: <59C10A00.2070000@googlemail.com> <20171214124841.7943b325@vento.lan> X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Em Wed, 7 Mar 2018 15:23:52 +0200 Antti Palosaari escreveu: > On 12/14/2017 04:48 PM, Mauro Carvalho Chehab wrote: > > Em Tue, 19 Sep 2017 13:13:52 +0100 > > Nigel Kettlewell escreveu: > > > >> [re-sending as plain text] > >> > >> Fix for hanging si2168 in PCTV 292e USB, making the code match the comment. > >> > >> Using firmware v4.0.11 the 292e would work once and then hang on > >> subsequent attempts to view DVB channels, until physically unplugged and > >> plugged back in. > >> > >> With this patch, the warm state is reset for v4.0.11 and it appears to > >> work both on the first attempt and on subsequent attempts. > > It is comment which is wrong. With firmware 4.0.11 it works well without > need of download it every time. But firmware 4.0.19 needs to be > downloaded every time after device is put to sleep. Ok. Let's then apply the enclosed patch (or something similar to it). > Probably your issue is coming from some other reason. I've no idea why Nigel proposed this patch. From my side, all I want is to update the status of this patch: https://patchwork.linuxtv.org/patch/44304/ and keep cleaning up my patch queue ;-) Thanks, Mauro [PATCH] media: si2168: fix a comment about firmware version There's a comment there at s82168 that it is wrong. With firmware 4.0.11, sleep/resume works well without need of download it every time. But firmware 4.0.19 needs to be downloaded again after sleep. Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c index a91947784842..324493e05f9f 100644 --- a/drivers/media/dvb-frontends/si2168.c +++ b/drivers/media/dvb-frontends/si2168.c @@ -614,7 +614,7 @@ static int si2168_sleep(struct dvb_frontend *fe) if (ret) goto err; - /* Firmware B 4.0-11 or later loses warm state during sleep */ + /* Firmware later than B 4.0-11 loses warm state during sleep */ if (dev->version > ('B' << 24 | 4 << 16 | 0 << 8 | 11 << 0)) dev->warm = false;