From patchwork Fri Apr 6 16:22:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mauro Carvalho Chehab X-Patchwork-Id: 10327219 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C4D896053F for ; Fri, 6 Apr 2018 16:23:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B44A52911E for ; Fri, 6 Apr 2018 16:23:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A7B40295A0; Fri, 6 Apr 2018 16:23:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A37162911E for ; Fri, 6 Apr 2018 16:22:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751540AbeDFQW6 (ORCPT ); Fri, 6 Apr 2018 12:22:58 -0400 Received: from osg.samsung.com ([64.30.133.232]:39747 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751412AbeDFQW5 (ORCPT ); Fri, 6 Apr 2018 12:22:57 -0400 Received: from localhost (localhost [127.0.0.1]) by osg.samsung.com (Postfix) with ESMTP id 17F61333B8; Fri, 6 Apr 2018 09:22:57 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at dev.s-opensource.com Received: from osg.samsung.com ([127.0.0.1]) by localhost (localhost [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ioCVAq606shR; Fri, 6 Apr 2018 09:22:55 -0700 (PDT) Received: from vento.lan (177.17.251.195.dynamic.adsl.gvt.net.br [177.17.251.195]) by osg.samsung.com (Postfix) with ESMTPSA id 8327D333AD; Fri, 6 Apr 2018 09:22:54 -0700 (PDT) Date: Fri, 6 Apr 2018 13:22:51 -0300 From: Mauro Carvalho Chehab To: Laurent Pinchart Cc: Linux Media Mailing List , Mauro Carvalho Chehab Subject: Re: [PATCH 18/21] media: isppreview: fix __user annotations Message-ID: <20180406132251.72b5f5c3@vento.lan> In-Reply-To: <9078125.KNKj9j4yVL@avalon> References: <9078125.KNKj9j4yVL@avalon> Organization: Samsung X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Em Fri, 06 Apr 2018 18:54:50 +0300 Laurent Pinchart escreveu: > Hi Mauro, > > Thank you for the patch. > > On Friday, 6 April 2018 17:23:19 EEST Mauro Carvalho Chehab wrote: > > That prevent those warnings: > > drivers/media/platform/omap3isp/isppreview.c:893:45: warning: incorrect > > type in initializer (different address spaces) > > drivers/media/platform/omap3isp/isppreview.c:893:45: expected void > > [noderef] *from drivers/media/platform/omap3isp/isppreview.c:893:45: > > got void *[noderef] > > drivers/media/platform/omap3isp/isppreview.c:893:47: warning: dereference > > of noderef expression > > That's nice, but it would be even nicer to explain what the problem is and how > you fix it, otherwise one might be left wondering if the fix is correct, or if > it could be a false positive. Ok. Please see the enclosed patch. > With the commit message updated, > > Reviewed-by: Laurent Pinchart Thanks, Mauro [PATCH] media: isppreview: fix __user annotations The 'from' variable at preview_config() expects an __user * type. However, the logic there does: from = *(void * __user *) ((void *)cfg + attr->config_offset); With actually means a void pointer, pointing to a void __ user pointer. When the first pointer is de-referenced with *(foo), the type it returns is "void *" instead of "void __user *". Change it to: from = *(void __user **) ((void *)cfg + attr->config_offset); in order to obtain, when de-referenced, a void __user pointer, as desired. That prevent those warnings: drivers/media/platform/omap3isp/isppreview.c:893:45: warning: incorrect type in initializer (different address spaces) drivers/media/platform/omap3isp/isppreview.c:893:45: expected void [noderef] *from drivers/media/platform/omap3isp/isppreview.c:893:45: got void *[noderef] drivers/media/platform/omap3isp/isppreview.c:893:47: warning: dereference of noderef expression Reviewed-by: Laurent Pinchart Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/platform/omap3isp/isppreview.c b/drivers/media/platform/omap3isp/isppreview.c index ac30a0f83780..c2ef5870b231 100644 --- a/drivers/media/platform/omap3isp/isppreview.c +++ b/drivers/media/platform/omap3isp/isppreview.c @@ -890,7 +890,7 @@ static int preview_config(struct isp_prev_device *prev, params = &prev->params.params[!!(active & bit)]; if (cfg->flag & bit) { - void __user *from = *(void * __user *) + void __user *from = *(void __user **) ((void *)cfg + attr->config_offset); void *to = (void *)params + attr->param_offset; size_t size = attr->param_size;