From patchwork Fri Apr 6 16:24:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mauro Carvalho Chehab X-Patchwork-Id: 10327223 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DFFA260208 for ; Fri, 6 Apr 2018 16:24:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CDEDA2911E for ; Fri, 6 Apr 2018 16:24:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BF652295A0; Fri, 6 Apr 2018 16:24:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 249D42911E for ; Fri, 6 Apr 2018 16:24:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751603AbeDFQYi (ORCPT ); Fri, 6 Apr 2018 12:24:38 -0400 Received: from osg.samsung.com ([64.30.133.232]:46721 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751412AbeDFQYi (ORCPT ); Fri, 6 Apr 2018 12:24:38 -0400 Received: from localhost (localhost [127.0.0.1]) by osg.samsung.com (Postfix) with ESMTP id 3A90F333F5; Fri, 6 Apr 2018 09:24:38 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at dev.s-opensource.com Received: from osg.samsung.com ([127.0.0.1]) by localhost (localhost [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gcClpPNrl-iB; Fri, 6 Apr 2018 09:24:36 -0700 (PDT) Received: from vento.lan (177.17.251.195.dynamic.adsl.gvt.net.br [177.17.251.195]) by osg.samsung.com (Postfix) with ESMTPSA id 81A47333EC; Fri, 6 Apr 2018 09:24:35 -0700 (PDT) Date: Fri, 6 Apr 2018 13:24:32 -0300 From: Mauro Carvalho Chehab To: Laurent Pinchart Cc: Linux Media Mailing List , Mauro Carvalho Chehab Subject: Re: [PATCH 17/21] media: ispstat: use %p to print the address of a buffer Message-ID: <20180406132432.7edd426a@vento.lan> In-Reply-To: <2465013.GQB41gvM8H@avalon> References: <76525da04eb7d8e5faaff7dc5173a05467b96965.1523024380.git.mchehab@s-opensource.com> <2465013.GQB41gvM8H@avalon> Organization: Samsung X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Em Fri, 06 Apr 2018 18:46:05 +0300 Laurent Pinchart escreveu: > Hi Mauro, > > Thank you for the patch. > > On Friday, 6 April 2018 17:23:18 EEST Mauro Carvalho Chehab wrote: > > Instead of converting to int, use %p. That prevents this > > warning: > > drivers/media/platform/omap3isp/ispstat.c:451 isp_stat_bufs_alloc() warn: > > argument 7 to %08lx specifier is cast from pointer > > > > Signed-off-by: Mauro Carvalho Chehab > > --- > > drivers/media/platform/omap3isp/ispstat.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/media/platform/omap3isp/ispstat.c > > b/drivers/media/platform/omap3isp/ispstat.c index > > 47cbc7e3d825..eb1b589b0aeb 100644 > > --- a/drivers/media/platform/omap3isp/ispstat.c > > +++ b/drivers/media/platform/omap3isp/ispstat.c > > @@ -449,10 +449,10 @@ static int isp_stat_bufs_alloc(struct ispstat *stat, > > u32 size) buf->empty = 1; > > > > dev_dbg(stat->isp->dev, > > - "%s: buffer[%u] allocated. dma=0x%08lx virt=0x%08lx", > > + "%s: buffer[%u] allocated. dma=0x%08lx virt=%p", > > stat->subdev.name, i, > > (unsigned long)buf->dma_addr, > > - (unsigned long)buf->virt_addr); > > + buf->virt_addr); > > While at it you can use %pad for buf->dma_addr. > > dev_dbg(stat->isp->dev, > "%s: buffer[%u] allocated. dma=%pad virt=%p", > stat->subdev.name, i, &buf->dma_addr, buf->virt_addr); > > With that change, > > Reviewed-by: Laurent Pinchart > > > } > > > > return 0; > OK. New patch enclosed. Thanks, Mauro [PATCH] media: ispstat: use %p to print the address of a buffer Instead of converting to int, use %p. That prevents this warning: drivers/media/platform/omap3isp/ispstat.c:451 isp_stat_bufs_alloc() warn: argument 7 to %08lx specifier is cast from pointer Reviewed-by: Laurent Pinchart Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/platform/omap3isp/ispstat.c b/drivers/media/platform/omap3isp/ispstat.c index 47cbc7e3d825..0b31f6c5791f 100644 --- a/drivers/media/platform/omap3isp/ispstat.c +++ b/drivers/media/platform/omap3isp/ispstat.c @@ -449,10 +449,8 @@ static int isp_stat_bufs_alloc(struct ispstat *stat, u32 size) buf->empty = 1; dev_dbg(stat->isp->dev, - "%s: buffer[%u] allocated. dma=0x%08lx virt=0x%08lx", - stat->subdev.name, i, - (unsigned long)buf->dma_addr, - (unsigned long)buf->virt_addr); + "%s: buffer[%u] allocated. dma=%pad virt=%p", + stat->subdev.name, i, &buf->dma_addr, buf->virt_addr); } return 0;