| Message ID | 20180418155309.274fe735@vento.lan (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Am Wed, 18 Apr 2018 15:53:09 -0300 schrieb Mauro Carvalho Chehab <mchehab@s-opensource.com>: > Em Wed, 18 Apr 2018 19:07:40 +0200 > Daniel Scheller <d.scheller.oss@gmail.com> escreveu: > > > Am Fri, 6 Apr 2018 13:46:03 -0300 > > schrieb Mauro Carvalho Chehab <mchehab@s-opensource.com>: > > > > > Em Sat, 7 Apr 2018 00:21:07 +0800 > > > kbuild test robot <lkp@intel.com> escreveu: > > > > > > > Hi Mauro, > > > > > > > > I love your patch! Yet something to improve: > > > > [...] > > > > > > Fixed patch enclosed. > > > > > > Thanks, > > > Mauro > > > > > > [PATCH] media: si470x: allow build both USB and I2C at the same > > > time > > > > > > Currently, either USB or I2C is built. Change it to allow > > > having both enabled at the same time. > > > > > > The main reason is that COMPILE_TEST all[yes/mod]builds will > > > now contain all drivers under drivers/media. > > > > > > Signed-off-by: Mauro Carvalho Chehab > > > <mchehab@s-opensource.com> > > > > FWIW, this patch (which seemingly is commit > > 58757984ca3c73284a45dd53ac66f1414057cd09 in media_tree.git) seems > > to break media_build in a way that on my systems only 20 drivers > > and modules are built now, while it should be in the 650+ modules > > range. Hans' automated daily testbuilds suffer from the same issue, > > looking at todays daily build logs (Wednesday.tar.bz2). I > > personally build against Kernel 4.16.2 on Gentoo. > > > > This specific commit/patch was found using > > > > # git bisect good v4.17-rc1 > > # git bisect bad media_tree/master > > > > And, "git revert 58767984..." makes all drivers being built again by > > media_build. > > > > Not sure if there's something other for which this patch acts as the > > trigger of if this needs adaption in media_build, though I thought > > reporting this doesn't hurt. > > > > Best regards, > > Daniel Scheller > > Please try this: > > diff --git a/drivers/media/radio/si470x/Makefile > b/drivers/media/radio/si470x/Makefile index > 563500823e04..682b3146397e 100644 --- > a/drivers/media/radio/si470x/Makefile +++ > b/drivers/media/radio/si470x/Makefile @@ -2,6 +2,6 @@ > # Makefile for radios with Silicon Labs Si470x FM Radio Receivers > # > > -obj-$(CONFIG_RADIO_SI470X) := radio-si470x-common.o > +obj-$(CONFIG_RADIO_SI470X) += radio-si470x-common.o > obj-$(CONFIG_USB_SI470X) += radio-si470x-usb.o > obj-$(CONFIG_I2C_SI470X) += radio-si470x-i2c.o That (ontop of media_tree.git HEAD) fixes it, back to 656 modules. Thanks! Best regards, Daniel Scheller
Em Wed, 18 Apr 2018 21:06:12 +0200 Daniel Scheller <d.scheller.oss@gmail.com> escreveu: > Am Wed, 18 Apr 2018 15:53:09 -0300 > schrieb Mauro Carvalho Chehab <mchehab@s-opensource.com>: > > > Em Wed, 18 Apr 2018 19:07:40 +0200 > > Daniel Scheller <d.scheller.oss@gmail.com> escreveu: > > > > > Am Fri, 6 Apr 2018 13:46:03 -0300 > > > schrieb Mauro Carvalho Chehab <mchehab@s-opensource.com>: > > > > > > > Em Sat, 7 Apr 2018 00:21:07 +0800 > > > > kbuild test robot <lkp@intel.com> escreveu: > > > > > > > > > Hi Mauro, > > > > > > > > > > I love your patch! Yet something to improve: > > > > > [...] > > > > > > > > Fixed patch enclosed. > > > > > > > > Thanks, > > > > Mauro > > > > > > > > [PATCH] media: si470x: allow build both USB and I2C at the same > > > > time > > > > > > > > Currently, either USB or I2C is built. Change it to allow > > > > having both enabled at the same time. > > > > > > > > The main reason is that COMPILE_TEST all[yes/mod]builds will > > > > now contain all drivers under drivers/media. > > > > > > > > Signed-off-by: Mauro Carvalho Chehab > > > > <mchehab@s-opensource.com> > > > > > > FWIW, this patch (which seemingly is commit > > > 58757984ca3c73284a45dd53ac66f1414057cd09 in media_tree.git) seems > > > to break media_build in a way that on my systems only 20 drivers > > > and modules are built now, while it should be in the 650+ modules > > > range. Hans' automated daily testbuilds suffer from the same issue, > > > looking at todays daily build logs (Wednesday.tar.bz2). I > > > personally build against Kernel 4.16.2 on Gentoo. > > > > > > This specific commit/patch was found using > > > > > > # git bisect good v4.17-rc1 > > > # git bisect bad media_tree/master > > > > > > And, "git revert 58767984..." makes all drivers being built again by > > > media_build. > > > > > > Not sure if there's something other for which this patch acts as the > > > trigger of if this needs adaption in media_build, though I thought > > > reporting this doesn't hurt. > > > > > > Best regards, > > > Daniel Scheller > > > > Please try this: > > > > diff --git a/drivers/media/radio/si470x/Makefile > > b/drivers/media/radio/si470x/Makefile index > > 563500823e04..682b3146397e 100644 --- > > a/drivers/media/radio/si470x/Makefile +++ > > b/drivers/media/radio/si470x/Makefile @@ -2,6 +2,6 @@ > > # Makefile for radios with Silicon Labs Si470x FM Radio Receivers > > # > > > > -obj-$(CONFIG_RADIO_SI470X) := radio-si470x-common.o > > +obj-$(CONFIG_RADIO_SI470X) += radio-si470x-common.o > > obj-$(CONFIG_USB_SI470X) += radio-si470x-usb.o > > obj-$(CONFIG_I2C_SI470X) += radio-si470x-i2c.o > > That (ontop of media_tree.git HEAD) fixes it, back to 656 modules. Good! I'll merge this with a proper description and apply ASAP. Regards, Mauro
diff --git a/drivers/media/radio/si470x/Makefile b/drivers/media/radio/si470x/Makefile index 563500823e04..682b3146397e 100644 --- a/drivers/media/radio/si470x/Makefile +++ b/drivers/media/radio/si470x/Makefile @@ -2,6 +2,6 @@ # Makefile for radios with Silicon Labs Si470x FM Radio Receivers # -obj-$(CONFIG_RADIO_SI470X) := radio-si470x-common.o +obj-$(CONFIG_RADIO_SI470X) += radio-si470x-common.o obj-$(CONFIG_USB_SI470X) += radio-si470x-usb.o obj-$(CONFIG_I2C_SI470X) += radio-si470x-i2c.o