| Message ID | 20180504180037.10661-1-ezequiel@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, May 04, 2018 at 03:00:37PM -0300, Ezequiel Garcia wrote: > The sync_debug.h header is internal, and only used by > sw_sync.c. Therefore, SW_SYNC is always defined and there > is no need for the stubs. Remove them and make the code > simpler. > > Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com> Applied, thanks. -Daniel > --- > drivers/dma-buf/sync_debug.h | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/drivers/dma-buf/sync_debug.h b/drivers/dma-buf/sync_debug.h > index d615a89f774c..05e33f937ad0 100644 > --- a/drivers/dma-buf/sync_debug.h > +++ b/drivers/dma-buf/sync_debug.h > @@ -62,8 +62,6 @@ struct sync_pt { > struct rb_node node; > }; > > -#ifdef CONFIG_SW_SYNC > - > extern const struct file_operations sw_sync_debugfs_fops; > > void sync_timeline_debug_add(struct sync_timeline *obj); > @@ -72,12 +70,4 @@ void sync_file_debug_add(struct sync_file *fence); > void sync_file_debug_remove(struct sync_file *fence); > void sync_dump(void); > > -#else > -# define sync_timeline_debug_add(obj) > -# define sync_timeline_debug_remove(obj) > -# define sync_file_debug_add(fence) > -# define sync_file_debug_remove(fence) > -# define sync_dump() > -#endif > - > #endif /* _LINUX_SYNC_H */ > -- > 2.16.3 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/dma-buf/sync_debug.h b/drivers/dma-buf/sync_debug.h index d615a89f774c..05e33f937ad0 100644 --- a/drivers/dma-buf/sync_debug.h +++ b/drivers/dma-buf/sync_debug.h @@ -62,8 +62,6 @@ struct sync_pt { struct rb_node node; }; -#ifdef CONFIG_SW_SYNC - extern const struct file_operations sw_sync_debugfs_fops; void sync_timeline_debug_add(struct sync_timeline *obj); @@ -72,12 +70,4 @@ void sync_file_debug_add(struct sync_file *fence); void sync_file_debug_remove(struct sync_file *fence); void sync_dump(void); -#else -# define sync_timeline_debug_add(obj) -# define sync_timeline_debug_remove(obj) -# define sync_file_debug_add(fence) -# define sync_file_debug_remove(fence) -# define sync_dump() -#endif - #endif /* _LINUX_SYNC_H */
The sync_debug.h header is internal, and only used by sw_sync.c. Therefore, SW_SYNC is always defined and there is no need for the stubs. Remove them and make the code simpler. Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com> --- drivers/dma-buf/sync_debug.h | 10 ---------- 1 file changed, 10 deletions(-)