From patchwork Wed May 30 22:07:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 10440047 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 047F3601E9 for ; Wed, 30 May 2018 22:08:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DEE6B29611 for ; Wed, 30 May 2018 22:08:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D8492296D0; Wed, 30 May 2018 22:08:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3B22C29694 for ; Wed, 30 May 2018 22:08:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932541AbeE3WH5 (ORCPT ); Wed, 30 May 2018 18:07:57 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:41101 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932431AbeE3WH4 (ORCPT ); Wed, 30 May 2018 18:07:56 -0400 Received: from wuerfel.lan ([95.208.111.237]) by mrelayeu.kundenserver.de (mreue101 [212.227.15.145]) with ESMTPA (Nemesis) id 0Letvr-1g6YXo3a9P-00qlCY; Thu, 31 May 2018 00:07:51 +0200 From: Arnd Bergmann To: Mauro Carvalho Chehab Cc: Arnd Bergmann , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] media: v4l: omap: add VIDEO_V4L2 dependency Date: Thu, 31 May 2018 00:07:11 +0200 Message-Id: <20180530220735.1651221-2-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20180530220735.1651221-1-arnd@arndb.de> References: <20180530220735.1651221-1-arnd@arndb.de> X-Provags-ID: V03:K1:A/P65lCfhg5b7st4LKQlZQ1GFxihGQepgmm4UTJSe37PMtGuzps dgRQ9+tOSgKUwmI85h2uABRyVD4b8rN04AHuM5t4i5cmvkZDj2rS/c5w0e+OsQRCx3mlZwP SZswI3wh/CgSxxDzMnWYqvJdC8eBfRRAoSLFRieabKN8NjSsB7RdujbkodN+VfH+5c/2+q4 gbVRCA9cD73ygxwpjNy2Q== X-UI-Out-Filterresults: notjunk:1; V01:K0:6k8HBU8lOcU=:U2HOSxcMEgIQKO1I+9inTh P+AXNuYQXhmU2xCc5AczeaUGRall4gjSHl38DlB3NmoPTlqNNH+VDdEs8/M1nM3ekOcgWWiAm POEYHFB8zhj+4eqMpI93g2oDEcSiG2xygZhAu6xiyLX4x3QfJOoqLrwjfVf8Sw/Kmf5MGrjCs jRnpMsg7OTe/LYJ/bV63sR+bvEF3A3+Ko3KxAs+3BY/3eZNDSPNjiDQ963vjfYAwqqxmTdA/K zhQcvd82HVEc76ifHuus0no7B2MzjckghC/pkGMfFuLDUWZsdQ8bnLPwSaqkqpcEPtl+JsuyO 6+piGQf7mOjleKpJwKhDrqOvNc7cDfHQNQkp5SGqjpYtLPF9P9MQEYvqFHCCz+JjsMtyFdUt7 yGNX8y1Ezxr1195onWYWkyUerxt27YWh0ITW2QpIMbziKNl0qQ0xjK9Cc1QkQYsQQaCSIFZFm 6qyjUf7imwBdknwWir4qa9NqAxk0+WpWyyl2L1UXoK1XQMlkPO99iMbYRlbB1bJjSBa9auz5/ uHYoo27CA1ovLYsvtVF+vDYBq4lTth4svgVP21b/VNFwoU0VlEIHkq3GREZxXnteCqjY3b02h VkRr+yAu80XurD+kbKh5kTB68BohNhwQxG7wU8P1udn8TCxSrVzEF9ZZzymPTynB5HkysZxBr 7eiNII+8XD5UL2phkaqjTAoMw9mV2lPXrh1varRHeoWmTZfWFReWEkLwXjSyJ4XHVMwA= Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The omap media driver can be built-in while the v4l2 core is a loadable module. This is a mistake and leads to link errors: drivers/media/platform/omap/omap_vout.o: In function `omap_vout_remove': omap_vout.c:(.text+0xec): undefined reference to `v4l2_device_unregister' omap_vout.c:(.text+0x140): undefined reference to `video_device_release' omap_vout.c:(.text+0x150): undefined reference to `video_unregister_device' omap_vout.c:(.text+0x15c): undefined reference to `v4l2_ctrl_handler_free' An explicit Kconfig dependency on VIDEO_V4L2 avoids the problem. I ran into this problem for the first time today during my randconfig builds, but could not find what caused it. Signed-off-by: Arnd Bergmann --- drivers/media/platform/omap/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/omap/Kconfig b/drivers/media/platform/omap/Kconfig index d827b6c285a6..4b5e55d41ad4 100644 --- a/drivers/media/platform/omap/Kconfig +++ b/drivers/media/platform/omap/Kconfig @@ -8,6 +8,7 @@ config VIDEO_OMAP2_VOUT depends on MMU depends on FB_OMAP2 || (COMPILE_TEST && FB_OMAP2=n) depends on ARCH_OMAP2 || ARCH_OMAP3 || COMPILE_TEST + depends on VIDEO_V4L2 select VIDEOBUF_GEN select VIDEOBUF_DMA_CONTIG select OMAP2_VRFB if ARCH_OMAP2 || ARCH_OMAP3