| Message ID | 20190613084926.bjxv2vdkp3qqpkuu@gofer.mess.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: rc: IR signal for Panasonic air conditioner too long sequences is too small | expand |
Dear Sean Young and all, In the last year, a change of the value of LIRCBUF_SIZE from 256 to 1024 was committed to the master branch at the time, and the new value can be used in the kernel 5.3 or later. https://github.com/torvalds/linux/commit/5c4c8b4a999019f19e770cb55cbacb89c95897bd#diff-3b71f634ae88214ee31a1b6c90f7df5c This change of LIRCBUF_SIZE was proposed in order to treat long IR sequences of remote controllers on Raspberry Pi. However, Raspberry Pi now uses kernel 4.19, so the new value cannot be used. Can you backport the above commit to the older kernels, i.e., 4.19, 4.20, 5.0, 5.1, and 5.2? Sincerely, Takashi Kanamaru 2019年6月13日(木) 17:49 Sean Young <sean@mess.org>: > > The IR signal to control the Panasonic ACXA75C00600 air conditioner has > 439 pulse/spaces. Increase limit to make it possible to transmit signal. > > Reported-by: Takashi Kanamaru <neuralassembly@gmail.com> > Signed-off-by: Sean Young <sean@mess.org> > --- > drivers/media/rc/lirc_dev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/rc/lirc_dev.c b/drivers/media/rc/lirc_dev.c > index 10830605c734..f078f8a3aec8 100644 > --- a/drivers/media/rc/lirc_dev.c > +++ b/drivers/media/rc/lirc_dev.c > @@ -19,7 +19,7 @@ > #include "rc-core-priv.h" > #include <uapi/linux/lirc.h> > > -#define LIRCBUF_SIZE 256 > +#define LIRCBUF_SIZE 1024 > > static dev_t lirc_base_dev; > > -- > 2.20.1 >
Hello stable team, Greg, On Mon, Apr 06, 2020 at 06:06:29PM +0900, Takashi Kanamaru wrote: > Dear Sean Young and all, > > In the last year, a change of the value of LIRCBUF_SIZE > from 256 to 1024 was committed to the master branch at the time, > and the new value can be used in the kernel 5.3 or later. > > https://github.com/torvalds/linux/commit/5c4c8b4a999019f19e770cb55cbacb89c95897bd#diff-3b71f634ae88214ee31a1b6c90f7df5c > > This change of LIRCBUF_SIZE was proposed > in order to treat long IR sequences of remote controllers > on Raspberry Pi. > > However, Raspberry Pi now uses kernel 4.19, > so the new value cannot be used. > > Can you backport the above commit > to the older kernels, i.e., > 4.19, 4.20, 5.0, 5.1, and 5.2? I'd like to propose this commit for the stable tree, from kernel 4.16 to 5.2. It has been in the tree from v5.3 onwards and no regressions have been found. Thank you, Sean > Sincerely, > > Takashi Kanamaru > > 2019年6月13日(木) 17:49 Sean Young <sean@mess.org>: > > > > The IR signal to control the Panasonic ACXA75C00600 air conditioner has > > 439 pulse/spaces. Increase limit to make it possible to transmit signal. > > > > Reported-by: Takashi Kanamaru <neuralassembly@gmail.com> > > Signed-off-by: Sean Young <sean@mess.org> > > --- > > drivers/media/rc/lirc_dev.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/media/rc/lirc_dev.c b/drivers/media/rc/lirc_dev.c > > index 10830605c734..f078f8a3aec8 100644 > > --- a/drivers/media/rc/lirc_dev.c > > +++ b/drivers/media/rc/lirc_dev.c > > @@ -19,7 +19,7 @@ > > #include "rc-core-priv.h" > > #include <uapi/linux/lirc.h> > > > > -#define LIRCBUF_SIZE 256 > > +#define LIRCBUF_SIZE 1024 > > > > static dev_t lirc_base_dev; > > > > -- > > 2.20.1 > >
On Mon, Apr 06, 2020 at 10:51:55AM +0100, Sean Young wrote: > Hello stable team, Greg, > > On Mon, Apr 06, 2020 at 06:06:29PM +0900, Takashi Kanamaru wrote: > > Dear Sean Young and all, > > > > In the last year, a change of the value of LIRCBUF_SIZE > > from 256 to 1024 was committed to the master branch at the time, > > and the new value can be used in the kernel 5.3 or later. > > > > https://github.com/torvalds/linux/commit/5c4c8b4a999019f19e770cb55cbacb89c95897bd#diff-3b71f634ae88214ee31a1b6c90f7df5c > > > > This change of LIRCBUF_SIZE was proposed > > in order to treat long IR sequences of remote controllers > > on Raspberry Pi. > > > > However, Raspberry Pi now uses kernel 4.19, > > so the new value cannot be used. > > > > Can you backport the above commit > > to the older kernels, i.e., > > 4.19, 4.20, 5.0, 5.1, and 5.2? > > I'd like to propose this commit for the stable tree, from kernel 4.16 to > 5.2. It has been in the tree from v5.3 onwards and no regressions have > been found. The only kernel being supported in that range is 4.19 at the moment, so I'll queue it up now, thanks. All other kernel trees are long end-of-life and no one should be using them anymore. thanks, greg k-h
diff --git a/drivers/media/rc/lirc_dev.c b/drivers/media/rc/lirc_dev.c index 10830605c734..f078f8a3aec8 100644 --- a/drivers/media/rc/lirc_dev.c +++ b/drivers/media/rc/lirc_dev.c @@ -19,7 +19,7 @@ #include "rc-core-priv.h" #include <uapi/linux/lirc.h> -#define LIRCBUF_SIZE 256 +#define LIRCBUF_SIZE 1024 static dev_t lirc_base_dev;
The IR signal to control the Panasonic ACXA75C00600 air conditioner has 439 pulse/spaces. Increase limit to make it possible to transmit signal. Reported-by: Takashi Kanamaru <neuralassembly@gmail.com> Signed-off-by: Sean Young <sean@mess.org> --- drivers/media/rc/lirc_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)